Re: testsuite failures when test scripts are run with zsh

2009-10-09 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Oct 10, 2009 at 03:42:52AM CEST: > At Friday 09 October 2009, Ralf Wildenhues wrote: > > I'd shorten this to: > > > > Use run_command throughout. > I'd prefer to keep it a bit more verbose. I settled for this: > "Use new subroutine run_command instead of hand

Re: [PATCH] Updating code enabling Bourne-compatibility in test scripts

2009-10-09 Thread Stefano Lattarini
At Friday 09 October 2009, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Fri, Oct 09, 2009 at 05:37:29PM CEST: > > The code snippet enabling Bourne-compatibility has been improved > > in autoconf since the 2.59c version, which was the version from > > which tests/defs.in stole its current

Re: [PATCH] Updating code enabling Bourne-compatibility in test scripts

2009-10-09 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Oct 09, 2009 at 05:37:29PM CEST: > The code snippet enabling Bourne-compatibility has been improved in > autoconf since the 2.59c version, which was the version from which > tests/defs.in stole its current Bourne-cmpatibility snippet. > > Thus it should better t

[PATCH] Updating code enabling Bourne-compatibility in test scripts

2009-10-09 Thread Stefano Lattarini
The code snippet enabling Bourne-compatibility has been improved in autoconf since the 2.59c version, which was the version from which tests/defs.in stole its current Bourne-cmpatibility snippet. Thus it should better to update tests/defs.in to use the newer snippet provided by autoconf 2.64.

[PATCH] Avoid leaking TEST_LOG_COMPILER in environment of test scripts

2009-10-09 Thread Stefano Lattarini
The automake test driver presently don't prevent the variable TEST_LOG_COMPILER from leaking into the test scripts. This can cause some weird errors when a developer decide to override the TEST_LOG_COMPILER from the command line when running the automake testsuite (as in e.g. `make check TEST_LOG_

Re: testsuite failures when test scripts are run with zsh

2009-10-09 Thread Stefano Lattarini
At Thursday 08 October 2009, Ralf Wildenhues wrote: > Hello Stefano, > > > Thanks. A few nits (and I hope you don't mind that I'm being > fairly nit-picky below): > > [CUT] > Cheers, and thanks for your work on this, > Ralf Wow, that was a lot of stuff! I think it will take me some time to re