The automake test driver presently don't prevent the variable
TEST_LOG_COMPILER from leaking into the test scripts. This can cause
some weird errors when a developer decide to override the 
TEST_LOG_COMPILER from the command line when running the automake
testsuite (as in e.g. `make check TEST_LOG_COMPILER=/bin/ksh', which
can be used to check that the test scripts are portable to ksh).

The just-one-line attached patch fixes this.

Regards,
     Stefano

From 5ebb0024e03afaa6df86132039a2369de3c099f8 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Thu, 8 Oct 2009 22:42:13 +0200
Subject: [PATCH] Avoid leaking TEST_LOG_COMPILER in environment of test scripts

* tests/defs.in: Unset variable `TEST_LOG_COMPILER'.
---
 ChangeLog     |    6 ++++++
 tests/defs.in |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b54cf75..90a12a3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-10-08  Stefano Lattarini  <stefano.lattar...@gmail.com>
+
+	Avoid leaking yet another environment variable which can uncorrectly
+	affect the behaviour of the test scripts.
+	* tests/defs.in: Unset variable `TEST_LOG_COMPILER'.
+
 2009-10-06  Bruno Haible  <br...@clisp.org>
 	    Ralf Wildenhues  <ralf.wildenh...@gmx.de>
 
diff --git a/tests/defs.in b/tests/defs.in
index 61182b6..06f8110 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -314,6 +314,7 @@ unset oldincludedir pdfdir psdir sbindir sharedstatedir sysconfdir
 # backward-compatible behavior.
 unset DISABLE_HARD_ERRORS
 unset TESTS
+unset TEST_LOG_COMPILER
 unset TEST_LOGS
 unset RECHECK_LOGS
 unset VERBOSE
-- 
1.6.3.3

Reply via email to