Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/ --- (Updated Oct. 23, 2013, 12:38 a.m.) Status -- This change has been di

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-02 Thread Anmol Ahuja
> On July 2, 2013, 3:03 p.m., Mark Kretschmann wrote: > > src/scriptengine/AmarokCollectionScript.cpp, line 39 > > > > > > Use the KDE_DEPRECATED macro I was intending the deprecation notification to be more for t

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-02 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/ --- (Updated July 2, 2013, 5:53 p.m.) Review request for Amarok and Mark Krets

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-02 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/#review35427 --- src/ScriptManager.h

Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-01 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/ --- Review request for Amarok and Mark Kretschmann. Description --- Week