Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-03-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/#review28692 --- This review has been submitted with commit 79adb8aba931c570597

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-16 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/#review25689 --- Is /opt/local for OSX ? Or is this used also on other platforms

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Yury Georgievich Kudryashov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/ --- (Updated Jan. 15, 2013, 4:26 a.m.) Review request for Amarok and Build Sys

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Yury Georgievich Kudryashov
> On Jan. 14, 2013, 6:12 p.m., Edward Hades Toroshchin wrote: > > cmake/modules/FindMySQLAmarok.cmake, line 25 > > > > > > /usr/mysql/include? Where's that? There was '/usr/mysql/include/mysql' in the original fil

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Yury Georgievich Kudryashov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/ --- (Updated Jan. 15, 2013, 4:23 a.m.) Review request for Amarok. Changes --

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Yury Georgievich Kudryashov
> On Jan. 14, 2013, 8:09 p.m., Alexander Neundorf wrote: > > Looks good. > > Is this file also installed ? > > Yes, amarok installs all *.cmake using GLOB. - Yury Georgievich --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/#review25519 --- Looks good. Is this file also installed ? - Alexander Neundor

Re: Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/#review25506 --- Looks good to me, I'd merge once 2.7 is released and after this

Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

2013-01-14 Thread Yury Georgievich Kudryashov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/ --- Review request for Amarok and Build System. Description --- FindMySQL