----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108413/#review25519 -----------------------------------------------------------
Looks good. Is this file also installed ? - Alexander Neundorf On Jan. 14, 2013, 4:54 p.m., Yury Georgievich Kudryashov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108413/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 4:54 p.m.) > > > Review request for Amarok and Build System. > > > Description > ------- > > FindMySQLAmarok.cmake: use PATH_SUFFIXES > > This way amarok finds mysql installed into a non-standard path in > CMAKE_PREFIX_PATH. > > I've dropped ~/usr support, since it is neither better nor worse than other > locations like ~/env, ~/root etc. If a user wants cmake to search in ~/usr, > he should use CMAKE_PREFIX_PATH. > > > Diffs > ----- > > cmake/modules/FindMySQLAmarok.cmake > 910b434bda138117a4a2598bd7f5aa5f3d58ee10 > > Diff: http://git.reviewboard.kde.org/r/108413/diff/ > > > Testing > ------- > > - install mysql into a non-standard path > - try to build amarok > > > Thanks, > > Yury Georgievich Kudryashov > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
