Re: Review Request: Playlist Queue Editor

2010-11-29 Thread Andreas Hartmetz
> On 2010-11-29 22:53:02, Leo Franchi wrote: > > Looks good to me now! I'd just shrink it a bit more.. the ratio is still > > fine, but the dialog is still quite large. There's room for 50+ queued > > tracks,that seems like overkill Pushed, thanks. (With a slightly smaller dialog) - Andr

Re: Review Request: Playlist Queue Editor

2010-11-29 Thread Leo Franchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review442 --- Ship it! Looks good to me now! I'd just shrink it a bit more.. t

Re: Review Request: Playlist Queue Editor

2010-11-29 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- (Updated 2010-11-29 18:11:59.652854) Review request for Amarok. Changes

Re: Review Request: Playlist Queue Editor

2010-11-29 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- (Updated 2010-11-29 17:49:53.425707) Review request for Amarok. Changes

Re: Review Request: Playlist Queue Editor

2010-11-28 Thread Leo Franchi
> On 2010-11-28 23:46:36, Leo Franchi wrote: > > Ok, a few comments from using it. Here are issues I think need to be > > addressed: > > > > * I think the action should be centered like the other actions below the > > playlist, probable with a separator. > > * I think the default size of the d

Re: Review Request: Playlist Queue Editor

2010-11-28 Thread Andreas Hartmetz
> On 2010-11-28 23:46:36, Leo Franchi wrote: > > Ok, a few comments from using it. Here are issues I think need to be > > addressed: > > > > * I think the action should be centered like the other actions below the > > playlist, probable with a separator. > > * I think the default size of the d

Re: Review Request: Playlist Queue Editor

2010-11-28 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- (Updated 2010-11-29 00:00:22.522696) Review request for Amarok. Changes

Re: Review Request: Playlist Queue Editor

2010-11-28 Thread Leo Franchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review436 --- Ok, a few comments from using it. Here are issues I think need to

Re: Review Request: Playlist Queue Editor

2010-11-28 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- (Updated 2010-11-28 23:26:33.655965) Review request for Amarok. Changes

Re: Review Request: Playlist Queue Editor

2010-11-28 Thread Leo Franchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review434 --- Code looks okay, will test functionality in a bit. Thanks! src/

Review Request: Playlist Queue Editor

2010-11-28 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- Review request for Amarok. Summary --- This adds a Queue Editor, with