Re: Review Request: Extend the scope of the playground

2012-09-04 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17841 --- I would like to see the code you are working on that has a need

Re: Review Request: Extend the scope of the playground

2012-09-04 Thread Bart Cerneels
> On Aug. 22, 2012, 8:25 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core. > > Matěj Laitl wrote: > Yup. I don't really think we should merge this. `git branch` is much > bet

Re: Review Request: Extend the scope of the playground

2012-09-04 Thread Matěj Laitl
> On Aug. 22, 2012, 8:25 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core. > > Matěj Laitl wrote: > Yup. I don't really think we should merge this. `git branch` is much > bet

Re: Review Request: Extend the scope of the playground

2012-09-04 Thread Ryan McCoskrie
> On Aug. 22, 2012, 8:25 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core. > > Matěj Laitl wrote: > Yup. I don't really think we should merge this. `git branch` is much > bet

Re: Review Request: Extend the scope of the playground

2012-08-24 Thread Matěj Laitl
> On Aug. 22, 2012, 8:25 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core. Yup. I don't really think we should merge this. `git branch` is much better tool than CMake variables a

Re: Review Request: Extend the scope of the playground

2012-08-22 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17840 --- I would like to see the code you are working on that has a need

Re: Review Request: Extend the scope of the playground

2012-08-20 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/ --- (Updated Aug. 19, 2012, 10:09 p.m.) Review request for Amarok. Descripti

Re: Review Request: Extend the scope of the playground

2012-08-17 Thread Ryan McCoskrie
> On Aug. 16, 2012, 11:14 a.m., Matěj Laitl wrote: > > The autor says he doesn't intend to see this merged, to I presume we can > > close this now. > > > > Ryan, as Bart says, there's some unrelated cleanup in this patch, could you > > please submit that as a separate review? Tracks. Done.

Re: Review Request: Extend the scope of the playground

2012-08-16 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17516 --- The autor says he doesn't intend to see this merged, to I presu

Re: Review Request: Extend the scope of the playground

2012-08-16 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17514 --- Personally I don't see the reason for a playground. If somebody

Re: Review Request: Extend the scope of the playground

2012-02-17 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review10693 --- There is some very welcome cleanup in this patch. I'm assuming