Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/#review3691 --- This review has been submitted with commit 4f61cd206bedc117b160

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/#review3690 --- Ship it! Nice work, ship it. - Kevin On June 5, 2011, 5:05 p

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/ --- (Updated June 5, 2011, 5:05 p.m.) Review request for Amarok. Changes ---

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Kevin Funk
> On June 5, 2011, 4:47 a.m., Bart Cerneels wrote: > > I think this is a nice feature. I've been starting to QtCreator full screen > > and yesterday indeed disabled track notifications in order to focus better. > > Guess my question is: should this also affect the notifications? > > Kevin Funk

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Martin Blumenstingl
> On June 5, 2011, 4:47 a.m., Bart Cerneels wrote: > > I think this is a nice feature. I've been starting to QtCreator full screen > > and yesterday indeed disabled track notifications in order to focus better. > > Guess my question is: should this also affect the notifications? > > Kevin Funk

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Kevin Funk
> On June 5, 2011, 4:47 a.m., Bart Cerneels wrote: > > I think this is a nice feature. I've been starting to QtCreator full screen > > and yesterday indeed disabled track notifications in order to focus better. > > Guess my question is: should this also affect the notifications? Yep, Martin, pl

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-04 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/#review3676 --- I think this is a nice feature. I've been starting to QtCreator

Review Request: Do not show the OSD if a fullscreen application is active

2011-06-04 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/ --- Review request for Amarok. Summary --- It can be quite annoying if fu