Re: Review Request: Album Artist for QueryMaker

2010-11-11 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review334 --- Ship it! Looks very sensible to me. I haven't run the code but i

Re: Review Request: Album Artist for QueryMaker

2010-11-10 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-10 19:35:59.303372) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

2010-11-10 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-10 15:25:41.998719) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

2010-11-06 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 22:10:42.870991) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

2010-11-06 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 19:58:32.908609) Review request for Amarok. Summary

Re: Review Request: Album Artist for QueryMaker

2010-11-06 Thread Stefan Derkits
> On 2010-11-06 14:28:07, Stefan Derkits wrote: > > src/browsers/CollectionTreeItemModelBase.cpp, line 402 > > > > > > The plural of index is either indices or indexes ... but not indixes :) > > Sergey Ivanov wrote:

Re: Review Request: Album Artist for QueryMaker

2010-11-06 Thread Sergey Ivanov
> On 2010-11-06 14:28:07, Stefan Derkits wrote: > > src/browsers/CollectionTreeItemModelBase.cpp, line 402 > > > > > > The plural of index is either indices or indexes ... but not indixes :) Ah, my English terrible,

Re: Review Request: Album Artist for QueryMaker

2010-11-06 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 14:41:00.191557) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

2010-11-06 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review310 --- src/browsers/CollectionTreeItemModelBase.cpp

Review Request: Album Artist for QueryMaker

2010-11-06 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- Review request for Amarok. Summary --- Add new QueryType - AlbumArtis