> On Aug. 3, 2011, 5:45 p.m., Ralf Engels wrote:
> > I support patches that make the code better. Even if it's just comments and
> > readability.
I can't commit it myself, so someone else has to do it.
Th
s/sql/PodcastFilenameLayoutConfigWidget.ui d913882
Diff: http://git.reviewboard.kde.org/r/102187/diff
Testing
---
Compiles and runs. Only made minor changes, so no actual testing required.
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-
/LastFmMeta.cpp 055dfef
Diff: http://git.reviewboard.kde.org/r/102181/diff
Testing
---
Tested with local files only. Cannot test with audio CD's since mine doesn't
work. Going to test Upnp and Ampache tracks and Daap tracks if possible.
Thanks
that's enough to inform the user that those tracks aren't
available)
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
sted on wiki markup
>is better spent coding and documenting inline. There's of course no
>problem in generating apidocs from there or even copying it to a wiki,
>but documentation in the code should come first.
>Cheers,
>--
>Teo
What you said does make
worked a lot better after reading that page.
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
>Wohooo. Thanks folks!
>Sandeep: Do you think you can help with making a list of stuff that
>you think really needs documenting? You could start a page for it in
>the wiki and everyone can add.
>
>Cheers
>Lydia
Ok, I'll do it. First though, I'll try to finish fixin
>> Woohoo, it worked.
>>
>> Added the file "Mainpage.dox" yesterday and pinged Allen (who
re-generated
>> the API docs).
>>
>> Greets
>
>Allen also fixed the file after that, obviously.
>
>Thanks, Allen
>Have a look here:
>
>
http://api.kde.org/extragear-api/multimedia-apidocs/amarok/html/inherits.html
>
>
>Regards, Myriam.
Hi,
The page looks good. Hopefully it'll help people understand Amarok's code
better.
Thanks,
Sandeep
est a page on the website with the class hierarchy (both
text and graphical). If it can be created automatically, then it can be kept
regularly updated (sort of like a nightly build) and if it needs to be
created manually, then occasionally is good enough.
Thanks,
Sa
Hi,
Is the doxygen generated documentation for amarok available somewhere
online? It just seems like a really useful thing for new contributors
(especially the class hierarchy).
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https
able".
>
> Bart
Hi,
Just so I'm clear on what I need to do. you're saying that I should
properly implement the isPlayable() function for all the *Track classes
derived from Meta::Track right?
-Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Hi,
Sorry about the double posting. My email client said it failed to send the
mail the first time.
-Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
le".
>
> Bart
Okay, I'll try that. The thing is I'm sort of new to Amarok development
(I only worked on the podcast part before) and it's a bit difficult to
understand the playlist part. It would be much easier if someone could
update this page http://amar
le".
>
> Bart
Okay, I'll try that. The thing is I'm sort of new to Amarok development
(I only worked on the podcast part before) and it's a bit difficult to
understand the playlist part. It would be much easier if someone could
update this page http://amar
might get some null pointers which also indicate
>> removed tracks.
>> (don't forget testing with audio streams and maybe some other
>> collections like when playing from a audio cd)
Shall I implement Meta::Track::isPlayable instead? It looks like it
would be easier that way.
Tha
dition to MetaProxy loading in XSPFPlaylist and other playlist
> classes.
>
Should I implement Meta::Track::isPlayable() and then use that to check
if the media is playable or not? It might make it easier.
-Sandeep
___
Amarok-devel mai
Thanks for all the replies.
-Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
display the current tracks after amarok is started up
> 4. display the current tracks and their status after amarok is started
> up
> 5. the rest.
>
> Look for the PlaylistController.cpp Amarok.cpp and Meta.h
>
> I am also on the Amarok chan
Hi,
Is there any way to see what tables exist in the embedded database used by
Amarok and the columns in those tables? Is it documented?
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok
>>On Mon, Jun 13, 2011 at 10:28, sandeep wrote:
>> Hi,
>> I was wondering if this is still open and is anyone working on it right
now?
>> Also, could someone please explain what exactly needs to be done here.
>Hey Sandeep :)
>
>When asking about bugs it helps to
Hi,
I was wondering if this is still open and is anyone working on it right now?
Also, could someone please explain what exactly needs to be done here.
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman
/diff
Testing
---
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
hanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
info
including which source it's from.
-Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ges though? Is there anything like copyright that
would prevent us from using such images? From the terms of service (
http://www.last.fm/api/tos) it says that last.fm data (which includes
images) can be used for noncommercial purposes, so that seems OK.
Hi,
Can someone please explain what exactly needs to be done here?
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Hi,
Is this still open? Just have to show a dialog if the files can't be found
right?
-Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
a.cpp fb82fa8
Diff: http://git.reviewboard.kde.org/r/100686/diff
Testing
---
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Hi,
I've decided to work on this. Could someone tell me which part of Amarok
this would come under? (playlist,collections etc.)
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e
src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08
Diff: http://git.reviewboard.kde.org/r/100686/diff
Testing
---
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
t; Checks are needed for all fields those can be absent.
>
> Sandeep Raghuraman wrote:
> As above, Album::prettyName() returns "Unknown Album", so this shouldn't
> be a problem. However, if you think it is I could change the code to check
> and replace by a spa
t; Checks are needed for all fields those can be absent.
>
> Sandeep Raghuraman wrote:
> As above, Album::prettyName() returns "Unknown Album", so this shouldn't
> be a problem. However, if you think it is I could change the code to check
> and replace by a space
ore updating
the channel filename contains "Unknown Artist" in place of %artist%, but after
updating the channel correct artist name is present.
- Sandeep
---
This is an automatically generated e-mail. To reply, visit:
http://git.r
-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e
src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08
src/core/podcasts/PodcastMeta.h e11b2eb
src/core/podcasts/PodcastMeta.cpp fb82fa8
Diff: http://git.reviewboard.kde.org/r/100686/diff
Testing
---
Thanks,
Sandeep
hen submit all the changes at once.
- Sandeep
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100686/#review1772
---
On Feb. 19
27;s SQL
> > specific.
> > Code formatting for readability.
I've implemented all changes except for the dialog appearance. I'm just not
able to get the dialog to display properly. Any tips on how to use QSizePolicy
so that
So far I have provided only %artist% and %title% for the custom filename
layout. Does anyone have any suggestions for other fields that can be
included?
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ng here, and why don't write just
> > filenameLayout == QLatin1String( "%default" ) instead?
>
> Sandeep Raghuraman wrote:
> Tried using QLatin1String, but I'm unable to figure out how to convert
> QString into QLatin1String. Should I change the original member variable
ng here, and why don't write just
> > filenameLayout == QLatin1String( "%default" ) instead?
Tried using QLatin1String, but I'm unable to figure out how to convert QString
into QLatin1String. Should I change the original member variable to
QLatin1String?
- Sandeep
---
I've submitted a review request for the filename configuration. Now, I've
added some extra code to replace the layout with the actual data - for
example replace %artist with the artist's name. Where should this code be
inserted? I've kept it in SqlPodcastProvider::downloadResult() but that
doesn't
src/core/podcasts/PodcastMeta.h e11b2eb
src/core/podcasts/PodcastMeta.cpp fb82fa8
Diff: http://git.reviewboard.kde.org/r/100686/diff
Testing
---
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org
://git.reviewboard.kde.org/r/100686/diff
Testing
---
Thanks,
Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
>I think you want to use git.reviewboard.kde.org.
I tried that, but I'm unable to log in with the same username and password
that I use in reviewboard.kde.org
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok
Hi,
I'm unable to publish review requests at reviewboard.kde.org. It doesn't
allow me to add any groups or reviewers and doesn't allow me to publish if
the 'Groups' or 'People' fields are empty. Could someone please help me? Is
it not working for anyone in general?
rs
in the podcast channel configuration dialog? I don't know how to implement
it in the second case.
-Sandeep
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Hi,
I'm working on this bug, and I wondered if the filename configuration should
come under general podcast settings or under each individual podcast
channel's settings. What's your opinion on this?
Sandeep
___
Amarok-devel mailing li
s are stored in the
database (which table,column names etc.) ?
Also, how should I store the new filename data? I've added two radio buttons
and a line edit box to the generic podcast config dialog as Fabian
suggested.
Yours sincerely,
Sandeep
___
Am
48 matches
Mail list logo
