> On March 11, 2011, 9:54 p.m., Sergey Ivanov wrote: > > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp, line 1461 > > <http://git.reviewboard.kde.org/r/100686/diff/2/?file=10665#file10665line1461> > > > > One more crash on track without album. > > Checks are needed for all fields those can be absent. > > Sandeep Raghuraman wrote: > As above, Album::prettyName() returns "Unknown Album", so this shouldn't > be a problem. However, if you think it is I could change the code to check > and replace by a space/empty string instead.
In some cases, an empty string is returned by some of the functions like QDateTime::toString. Will this cause a crash? Is that what you're talking about? - Sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review1910 ----------------------------------------------------------- On March 6, 2011, 7:23 p.m., Sandeep Raghuraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100686/ > ----------------------------------------------------------- > > (Updated March 6, 2011, 7:23 p.m.) > > > Review request for Amarok and Bart Cerneels. > > > Summary > ------- > > Adds a dialog to configure podcast episode filenames. Added a filenamelayout > column to podcastchannels table and a member to PodcastMeta to hold the > filename layout. Podcast database version updated to 5. > > > This addresses bug 155075. > https://bugs.kde.org/show_bug.cgi?id=155075 > > > Diffs > ----- > > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h PRE-CREATION > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp > PRE-CREATION > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigWidget.ui > PRE-CREATION > src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp de53d77 > src/core-impl/podcasts/sql/SqlPodcastMeta.h 5bda713 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08 > src/core/podcasts/PodcastMeta.h e11b2eb > src/core/podcasts/PodcastMeta.cpp fb82fa8 > > Diff: http://git.reviewboard.kde.org/r/100686/diff > > > Testing > ------- > > > Thanks, > > Sandeep > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
