Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

ics/LyricsEngine.cpp 2befa91 src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919b Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

and, user may want to know > > whether lyrics have been previously edited by her. Additionally, some file > > formats allow storing lyrics in tags, it would be nice if Amarok supported > > it. (then it would make sense to show her what is the source of lyrics > > being shown) &

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

his is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109470/#review30013 ----------- On March 27, 2013, 7:22 p.m., mayank jha wrote: > > --- >

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

d and new. Diffs (updated) - src/context/engines/lyrics/LyricsEngine.cpp 2befa91 src/context/applets/lyrics/LyricsApplet.cpp 2394964 src/context/engines/lyrics/LyricsEngine.h b187b73 Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing --- Its working fine!

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

ntext/applets/lyrics/LyricsApplet.cpp 2394964 src/context/engines/lyrics/LyricsEngine.h b187b73 src/context/engines/lyrics/LyricsEngine.cpp 2befa91 Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing --- Its working fine!

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

de.org/r/109470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

application for Project: Improving and modularizing tag guessing

I am Mayank Kumar Jha, a B.Tech 2nd year student, National Institute of Technology, Durgapur, India. I am really interested into doing a project involving Qt, QML. I am well-versed in C,C++. Have a first hand knowledge of Python,Qt and HTML. I strongly believe in the principles of FOSS and am reall

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

9470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

9470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109464: Patch which tries to fix the ordering error while tracks are copied from the hard disk to some other storage device

working! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

subscribe

___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

subscribe

___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

9470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

ded/files/2013/03/14/lyrcach.diff lyrics applet changes http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/lyrcach2.diff Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

quot;Lyrics" so we can tell the difference between old and new. Diffs - Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org

Re: Review Request 109464: Patch which tries to fix the ordering error while tracks are copied from the hard disk to some other storage device

/ Testing --- seems to be working! File Attachments (updated) http://git.reviewboard.kde.org/media/uploaded/files/2013/03/13/new.diff Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org

Re: Review Request 109464: Patch which tries to fix the ordering error while tracks are copied from the hard disk to some other storage device

/ Testing --- seems to be working! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

quot;Lyrics" so we can tell the difference between old and new. Diffs - Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing --- Its working fine! File Attachments (updated) http://git.reviewboard.kde.org/media/uploaded/files/2013/03/13/lyrcach.di

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

quot;Lyrics" so we can tell the difference between old and new. Diffs - Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing --- Its working fine! Thanks, mayank jha ___ Amarok-devel mailing list Amarok-devel@kde.org