----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109470/ -----------------------------------------------------------
(Updated April 4, 2013, 11:37 p.m.) Review request for Amarok. Changes ------- Adds the proper fix alongwith the not affecting cached lyrics stuff. should I removenthe cached lyrics completely? Description ------- It required modifications, when there is no change in the lyrics downloaded and lyrics retrieved from cache the title display of the lyrics browser changes to "Cached Lyrics" from "Lyrics" so we can tell the difference between old and new. Diffs (updated) ----- CMakeLists.txt d167577 src/context/applets/lyrics/LyricsApplet.cpp 2394964 src/context/engines/lyrics/LyricsEngine.h b187b73 src/context/engines/lyrics/LyricsEngine.cpp 2befa91 src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919b Diff: http://git.reviewboard.kde.org/r/109470/diff/ Testing ------- Its working fine! Thanks, mayank jha
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
