Re: Review Request 114563: Make sure not to use video stream when transcoding to Opus

picture) and Opus. Thus, this patch makes sure not to use video streams. Diffs - src/core/transcoding/formats/TranscodingOpusFormat.cpp dc6b743 Diff: https://git.reviewboard.kde.org/r/114563/diff/ Testing --- Thanks, Martin Brodbeck

Re: Review Request 114563: Make sure not to use video stream when transcoding to Opus

this problem. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114563/#review45950 --- On Dec. 20, 2013, 11:06 a.

Review Request 114563: Make sure not to use video stream when transcoding to Opus

/transcoding/formats/TranscodingOpusFormat.cpp dc6b743 Diff: http://git.reviewboard.kde.org/r/114563/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

displayed. This will fix bug #328451. Diffs - ChangeLog 107aa48 shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c Diff: http://git.reviewboard.kde.org/r/114406/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

> On Dec. 12, 2013, 1:52 p.m., Mark Kretschmann wrote: > > The "Ship It" is just a default text from ReviewBoard, it's not to be taken > > literally. Of course we can commit it for you :) I'll do it tonight when > > I'm back home. > > Mar

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

/git.reviewboard.kde.org/r/114406/#review45597 ------- On Dec. 12, 2013, 11:51 a.m., Martin Brodbeck wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

dc02a1c Diff: http://git.reviewboard.kde.org/r/114406/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

- shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c Diff: http://git.reviewboard.kde.org/r/114406/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

Diff: http://git.reviewboard.kde.org/r/114406/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108907: Added transcoding for opus format

> On Feb. 26, 2013, 12:50 p.m., Martin Brodbeck wrote: > > Ship It! > > Matěj Laitl wrote: > > Stupid me, there's never a faultless patch from me. :-/ > > No faultless patch was ever posted to reviewboard, at least not when I'm > the re

Re: Review Request 108907: Added transcoding for opus format

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/#review28125 --- Ship it! Ship It! - Martin Brodbeck On Feb. 26, 2013, 8:08

Re: Review Request 108907: Added transcoding for opus format

ATION src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/108907/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 108907: Added transcoding for opus format

://git.reviewboard.kde.org/r/108907/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108907: Added transcoding for opus format

src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION src/core/CMakeLists.txt 2809dc3 Diff: http://git.reviewboard.kde.org/r/108907/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org

Re: Review Request 108907: Added transcoding for opus format

/transcoding/formats/TranscodingOpusFormat.h PRE-CREATION src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION src/core/CMakeLists.txt 2809dc3 Diff: http://git.reviewboard.kde.org/r/108907/diff/ Testing --- Thanks, Martin Brodbeck

Re: Review Request 108542: Support for .opus file tags added

63a83e1 shared/config.h.cmake 004dd57 shared/tag_helpers/TagHelper.cpp 4534018 shared/FileType.h b3d4470 README c49d284 Diff: http://git.reviewboard.kde.org/r/108542/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list

Re: Review Request 108907: Added transcoding for opus format

/transcoding/TranscodingController.cpp 265d1f8 src/core/transcoding/TranscodingDefines.h 8c68f15 Diff: http://git.reviewboard.kde.org/r/108907/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https

Review Request 108907: Added transcoding for opus format

/transcoding/TranscodingDefines.h 8c68f15 Diff: http://git.reviewboard.kde.org/r/108907/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108542: Support for .opus file tags added

shared/FileType.cpp 43d8777 shared/FileTypeResolver.cpp 63a83e1 shared/config.h.cmake 004dd57 shared/tag_helpers/TagHelper.cpp 4534018 shared/FileType.h b3d4470 README c49d284 Diff: http://git.reviewboard.kde.org/r/108542/diff/ Testing --- Thanks, Marti

Re: Review Request 108542: Support for .opus file tags added

y, visit: http://git.reviewboard.kde.org/r/108542/#review27046 ------- On Jan. 22, 2013, 4:30 p.m., Martin Brodbeck wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 108542: Support for .opus file tags added

://git.reviewboard.kde.org/r/108542/#review25977 ------- On Jan. 22, 2013, 4:30 p.m., Martin Brodbeck wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 108542: Support for .opus file tags added

b3d4470 shared/FileType.cpp 43d8777 shared/FileTypeResolver.cpp 63a83e1 shared/config.h.cmake 004dd57 shared/tag_helpers/TagHelper.cpp 4534018 Diff: http://git.reviewboard.kde.org/r/108542/diff/ Testing --- Thanks, Martin Brodbeck

Review Request 108542: Support for .opus file tags added

/tag_helpers/TagHelper.cpp 45340180139b9ac0604ad93483dd9fd725a4cb02 Diff: http://git.reviewboard.kde.org/r/108542/diff/ Testing --- Thanks, Martin Brodbeck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo