Re: getamarok.com mail forwarding broken

I can't log in using save credentials that used to work. Could it be google terminated our apps in the recent move to none-free? On Tue, Jul 16, 2013 at 1:13 PM, Sven Krohlas wrote: > Heya, > > I tried to contact eean but got no reply. It seems as if mail forwarding > from our getamarok.com mail

Re: CUE sheets in collection still not working :(

On Sun, Apr 14, 2013 at 12:11 PM, Matěj Laitl wrote: > > On 11. 4. 2013 Myriam Schweingruber wrote: > > Hi all, > > > > This is just a reminder for https://bugs.kde.org/show_bug.cgi?id=187587 > > > > This is a long standing bug and the one with the highest amount of votes: > > 751 > > > > It would

Re: Review Request 107473: Changes in processing playlist files

t. That is easy in a feature branch. - Bart Cerneels On April 1, 2013, 6:57 p.m., Tatjana Gornak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 108686: hidden items in context menu: usability question

tries is a new UI concept that I have never seen before. > If that is used wider (e.g. in whole KDE) then I am cool with it. > Currently exactly two context menues are using it. So even we are not > consistent in it's use. > > Bart Cerneels wrote: > Shift for del

Re: Review Request 108686: hidden items in context menu: usability question

tries is a new UI concept that I have never seen before. > If that is used wider (e.g. in whole KDE) then I am cool with it. > Currently exactly two context menues are using it. So even we are not > consistent in it's use. > > Bart Cerneels wrote: > Shift for del

Re: [amarok] src: Remove unused AudioCdTrackProvider

Wasn't this part of AudioCdCollection? How did that ever work? On Sun, Feb 17, 2013 at 6:39 PM, Matěj Laitl wrote: > Git commit d6251e08012056b1e3920edb7ae2d451bcdf9218 by Matěj Laitl. > Committed on 17/02/2013 at 18:38. > Pushed by laitl into branch 'master'. > > Remove unused AudioCdTrackProvid

Re: Review Request 108686: hidden items in context menu: usability question

On Mon, Feb 18, 2013 at 3:29 PM, Edward Hades Toroshchin wrote: > On Mon, Feb 18, 2013 at 02:22:14PM -0000, Bart Cerneels wrote: >> Yes I am, it's nice and cool here. Don't have much chance to check the >> commits though. Shouldn't this review have been closed alre

Re: Review Request 108686: hidden items in context menu: usability question

tries is a new UI concept that I have never seen before. > If that is used wider (e.g. in whole KDE) then I am cool with it. > Currently exactly two context menues are using it. So even we are not > consistent in it's use. > > Bart Cerneels wrote: > Shift for del

Re: Review Request 108686: hidden items in context menu: usability question

> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

> On Feb. 12, 2013, 2:49 p.m., Matěj Laitl wrote: > > I don't think creating a custom subclass is the right way to implement drag > > & drop support. The right way should be implementing QAbstractItemModel for > > the queue (with drag&drop methods) and then the GUI would automatically > > supp

Re: Review Request 108905: Move UI code of PlaylistQueueEditor from .ui to .cpp file

> On Feb. 11, 2013, 5:40 p.m., Bart Cerneels wrote: > > Use a promoted widget instead. UI forms superior to this, we prefer to use > > them more, not less. > > > > FYI the QueueEditor feature is not something we'll keep around for long. > > It's sch

Re: Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

ttp://git.reviewboard.kde.org/r/108906/#comment20495> Like I suspected in the other review, there is no reason not to use a promoted widget. - Bart Cerneels On Feb. 11, 2013, 10:43 a.m., Bartosz Szreder wrote: > > --- > This is an automati

Re: Review Request 108905: Move UI code of PlaylistQueueEditor from .ui to .cpp file

prefer to use them more, not less. FYI the QueueEditor feature is not something we'll keep around for long. It's scheduled to be completely replaced one or two releases from now. Consider that before you spend days of useful coding time on it. - Bart Cerneels On Feb. 11, 2013,

Re: Review Request 107473: Changes in processing playlist files

> On Feb. 9, 2013, 12:55 a.m., Matěj Laitl wrote: > > src/core-impl/playlists/types/file/PlaylistFile.h, lines 71-73 > > > > > > What is the difference between save() and savePlaylist()? Also, if we > > don't allo

Re: Review Request: Changes in processing playlist files

<http://git.reviewboard.kde.org/r/107473/#comment18709> This comment is just confusing. Mentions implementation. - Bart Cerneels On Dec. 29, 2012, 12:46 p.m., Tatjana Gornak wrote: > > --- > This is an automa

Re: Review Request: Changes in processing playlist files

> On Nov. 27, 2012, 8:08 a.m., Bart Cerneels wrote: > > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp, line 218 > > <http://git.reviewboard.kde.org/r/107473/diff/1/?file=96233#file96233line218> > > > > Here is the real reason why lazy loading is n

Re: Review Request: Changes in processing playlist files

version. Clicking publish because I don't know what was not pushed yet. - Bart Cerneels On Dec. 29, 2012, 12:46 p.m., Tatjana Gornak wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Fix one small memoy leak when switch track in amarok

, but if it's executed on each track change it likely is a real leak. Test if it doesn't cause dangling pointer crashes and ship it. - Bart Cerneels On Dec. 31, 2012, 2:06 p.m., Jekyll Wu wrote: > > --- > This is an a

Re: Review Request: Layout changes to organize collection, guess metadata, edit filter and edit playlist layout dialogs

4, don't use a combo. And don't make it this wide in any case. - Bart Cerneels On Dec. 7, 2012, 11:44 a.m., Ralf Engels wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request: Playlists::Playlist: add metadataChanged() to observer, clean-up, docs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107484/#review22640 --- Ship it! Merge this. - Bart Cerneels On Nov. 27, 2012, 12

Re: Review Request: Playlists::Playlist: add metadataChanged() to observer, clean-up, docs

ttp://git.reviewboard.kde.org/r/107484/#comment17318> You missed the opportunity to move this to Meta namespace. Much work elsewhere though. There, now I have a issue for an otherwise perfect patch ;) - Bart Cerneels On Nov. 27, 2012, 12:01 p.m., Matěj Laitl

Re: Review Request: Changes in processing playlist files

myself: http://quickgit.kde.org/?p=amarok.git&a=blob&h=3eda255d944f61c3f975031b69b342cf0899fc2b&hb=57e5bf466b364a0e086000b2d24f00e1e336b22e&f=HACKING%2Farchitecture%2FPlaylists.txt It's in HACKING/architecture/ - Bart Cerneels On Nov. 26, 2012, 12:10 p.m.,

Re: Review Request: Changes in processing playlist files

> On Nov. 27, 2012, 8:08 a.m., Bart Cerneels wrote: > > I think you started with the wrong assumption that lazy loading of the > > contents of the playlist file is required. > > We have some use cases for PlaylistFile: > > 1) Make playlists found in the collection fo

Re: Review Request: Changes in processing playlist files

tionManager::trackForUrl() is problematic. It should either block until the track is ready (depends in TrackProviders) or using proxy loading like it is now. The proxy is temporary and gets initialized with metadata we know from the contents of this playlist file. - Bart Cerneels On Nov.

Re: Access data for the new server needed

Hey Myriam i had these details but assumed Bradley had send them already to Ben, GPG encrypted. I just forwarded the plain text login details to sysadmin, they'll have to set-up a secure system anyway. On Tue, Nov 20, 2012 at 11:44 AM, Myriam Schweingruber wrote: > Hi Bradley, > > this as a shor

Re: Nepomuk Collection

On Fri, Nov 9, 2012 at 4:35 PM, Matěj Laitl wrote: > On 9. 11. 2012 Phalgun Guduthur wrote: >> Hello all > > Hi, > >> After a period of inactivity, I want to continue working on the Nepomuk >> plugin for Amarok and implement a few more features before it is shipped. > > Good! > >> These are the ma

Re: GPL-incompatibility of Spotify's libspotify API ToU (was Re: Getting a Spotify Premium account for Amarok)

On Mon, Nov 12, 2012 at 9:02 PM, Bradley M. Kuhn wrote: > Amarok Committee, > > Bart, Tony, and I discussed the issue with spotify on IRC today. I > hadn't realized (until today when Bart told me) that a GSoC student had > added support for spotify to Amarok. Conservancy only became aware of > t

Fwd: GPL-incompatibility of Spotify's libspotify API ToU (was Re: Getting a Spotify Premium account for Amarok)

mpatibility of Spotify's libspotify API ToU (was Re: Getting a Spotify Premium account for Amarok) To: Bart Cerneels , ama...@sfconservancy.org Cc: Tony Sebro Amarok Committee, Bart, Tony, and I discussed the issue with spotify on IRC today. I hadn't realized (until today when Bart tol

Fwd: FOSDEM CrossDesktop DevRoom 2013 - Call for Talks

-- Forwarded message -- From: Pau Garcia i Quiles Date: Wed, Oct 31, 2012 at 5:50 PM Subject: FOSDEM CrossDesktop DevRoom 2013 - Call for Talks To: kde-de...@kde.org, kdelibs , KDE on Windows , Calligra Suite developers and users mailing list Hello, The Call for Talks for the C

Re: Review Request: collectionscanner: prevent writing malformed XML

ormed XML. - Bart Cerneels On Oct. 25, 2012, 2:26 p.m., Edward Hades Toroshchin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

to solve another bug with password protected shares. As far as I can tell this one could also have fixed that, but it didn't work. Will need to dive deeper in DAAP to figure it out, but man, is that a crap protocol. - Bart Cerneels On Sept. 30, 2012, 7:28 p.m., Daniel Stöckel

Re: Review Request: Refactoring of Collection config UI code

expand. As long as the combo is large enough to hold the longest string it's OK. Wide comboboxes are ugly. - Bart Cerneels On Oct. 8, 2012, 11:31 a.m., Mark Kretschmann wrote: > > --- > This is an automatic

Re: [UI] QML CV usability feedback

On Fri, Sep 28, 2012 at 3:47 PM, Thomas Pfeiffer wrote: > Hi everyone, > I've now compiled the QML branch of Amarok and will give some feedback to the > new Context View, as promised about a month ago. I'm addressing the whole list > since I'm not sure who will be working on the CV in the near fut

Re: Review Request: phonon phive core frontend api

> On Sept. 26, 2012, 7:42 p.m., Bart Cerneels wrote: > > core/Player.h, line 39 > > <http://git.reviewboard.kde.org/r/106566/diff/1/?file=87102#file87102line39> > > > > Should be addAudioOutput and addVideoOutput if you want to keep them > > separate.

Re: Review Request: phonon phive core frontend api

Get the list of subtitles from the source. core/effects/SubtitleEffect.h <http://git.reviewboard.kde.org/r/106566/#comment15412> properties needed. - Bart Cerneels On Sept. 25, 2012, 11:06 a.m., Harald Sitter wrote: > > ---

[amarok] src: Give proper place for inactive authors.

Git commit 927187797df79af7ea6ccf3f16563d83cafb232f by Bart Cerneels. Committed on 25/09/2012 at 08:49. Pushed by shanachie into branch 'master'. Give proper place for inactive authors. CCMAIL:amarok-devel@kde.org M +31 -15 src/main.cpp http://commits.kde.

Re: Authorship

On Mon, Sep 24, 2012 at 7:31 PM, Jeff Mitchell wrote: > On 09/24/2012 09:51, Valorie Zimmerman wrote: >> >> On Sat, Sep 22, 2012 at 11:17 PM, Bart Cerneels >> wrote: >>> >>> The currently active Amarok team has defined the authors list to >>>

Re: Review Request: MetaFile::Track: only provide statistics stored in tags

I guess the name does not matter much. - Bart Cerneels On Sept. 23, 2012, 11:39 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Status update: KIO-MTP

reviewboard.kde.org (make sure to put me in the reviewers list nick: shanachie) and yes, upload the complete code. On Mon, Sep 24, 2012 at 10:14 AM, Philipp Schmidt wrote: > Hi, > > Am Montag, 24. September 2012, 08:03:07 schrieb Bart Cerneels: >> Cloned it and compiled without

Re: Status update: KIO-MTP

On Sun, Sep 23, 2012 at 11:55 PM, Philipp Schmidt wrote: > Hi all, > > just a little status update on the kio-mtp progress. The Project is now in > playground. You can find it here: > > https://projects.kde.org/projects/playground/base/kio-mtp > > The most important changes: > - More stability >

Re: Authorship

On Sun, Sep 23, 2012 at 10:49 AM, Alex Fiestas wrote: > Hey... > > Sorry if this topic wasn't one to joke about, yesterday night I was told of > the tensions going on because of the changes and it seemed that a little > joke will chill the environment a little bit. > > If you take a look at the ye

Authorship

The currently active Amarok team has defined the authors list to contain current contributors that have ownership (written it or maintaining it for a while) of amarok components or non-coding contributions to the project. As far as I can tell there is no legal reason to list all past contributors a

Re: Review Request: add cli argument to activate phonon debugging

arate from the regular debug. Less risk of it getting lost in the noise but might miss EngineController context. So I agree with matej's suggestion. Ship this one already though. - Bart Cerneels On Sept. 12, 2012, 11:35 a.m., Harald Si

Re: TODO for 2.7: android MTP

On Mon, Sep 10, 2012 at 9:56 PM, Philipp Schmidt wrote: > Am Montag, 10. September 2012, 17:06:57 schrieb Matěj Laitl: >> On 10. 9. 2012 Bart Cerneels wrote: >> > Having recently bought a Galaxy 3 I can confirm, we need have very >> > good MTP support i.e. rewrite M

Re: API proposal: Phonon BackendInfo

On Sun, Sep 9, 2012 at 3:04 PM, Harald Sitter wrote: > On Sun, Sep 9, 2012 at 2:14 PM, Matěj Laitl wrote: >>> /** @returns \c true when this backend was provided by a platform plugin >>> */ >>> bool isPlatformProvided() const; >> >> Perhaps this has sense to people who known how Phono

TODO for 2.7: android MTP

http://amarok.kde.org/en/releases/2.6#comment-14114 Having recently bought a Galaxy 3 I can confirm, we need have very good MTP support i.e. rewrite MtpCollection. For anyone taking it on (/me looks in the general direction of strohel) I might have a device you can use. Bart

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

s about the functionality. > (and not answer your specific points because that is useless unless we > agree on the requirements) > > I would like all collections to have full statistics support. > Where the underlying mechanisms don't support it I want to have a de

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote: > > There are some welcome changes in this patch: > > * ability to implement statistics by inheritance > > * StatisticsCapability removal > > > > However, there are some things I dislike: > > * Meta::Track inheriting AbstractStatistics > > *

Re: Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

ll have to look into. - Bart Cerneels On Sept. 8, 2012, 7:11 p.m., Daniel Stöckel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

> On Sept. 7, 2012, 12:34 p.m., Bart Cerneels wrote: > > src/core-impl/collections/daap/DaapMeta.cpp, line 43 > > <http://git.reviewboard.kde.org/r/106366/diff/2/?file=84097#file84097line43> > > > > Since the playable url now contains a session ID, I wonder

Re: Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

long after startup. src/core-impl/collections/daap/daapreader/Reader.cpp <http://git.reviewboard.kde.org/r/106366/#comment14746> I would move the login assignment to below the connect. - Bart Cerneels On Sept. 7, 2012, 12:16 p.m., Dan

Re: Review Request: Fix Permission denied when playing a track from a Rhythmbox DAAP collection

/ with these new changes and close this one. Will review there. For help to update the review-request ask on #amarok on irc.freenode.org. - Bart Cerneels On Sept. 7, 2012, 9:51 a.m., Daniel Stöckel wrote: > > --- > This is an auto

Re: Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

can expect more patches from you. Is there a published spec we can develop against? I'll test later that this still works with the mt-daap I'm running (Firefly Media Server: Version svn-1676 on a netgear readynas Duo v1) - Bart Cerneels On Sept. 7, 2012, 9:45 a.m., Daniel Stö

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Sept. 4, 2012, 6:11 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.h, line 42 > > > > > > Nicpick: instead -> "in addition to" It actually is the goal of the nepomuk

Re: Review Request: Extend the scope of the playground

need for this change. I still think that it should go directly in core. - Bart Cerneels On Aug. 19, 2012, 10:09 p.m., Ryan McCoskrie wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: Extend the scope of the playground

> On Aug. 22, 2012, 8:25 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core. > > Matěj Laitl wrote: > Yup. I don't really think we should mer

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

ve to look into StatisticsProvider in general before I can comment further. - Bart Cerneels On Aug. 30, 2012, 12:03 p.m., Ralf Engels wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, line 281 > > > > > > Register the job with Amarok::Components::logger(), mentioning its > >

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 20, 2012, 10:46 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h, line > > 71 > > > > > > This is an important design issue: > > > > You either ne

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

On Sat, Aug 18, 2012 at 12:13 PM, Matěj Laitl wrote: > On 17. 8. 2012 Edward Toroshchin wrote: >> > Don't take it personally, but if you don't revert I'm going to. >> >> Don't take it personally, but I believe you need at least someone else >> to back you up on this to revert anything. Currently,

Re: Review Request: Extend the scope of the playground

need for this change. I still think that it should go directly in core. - Bart Cerneels On Aug. 19, 2012, 10:09 p.m., Ryan McCoskrie wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: magnatune: first update related tweaks

> On Aug. 18, 2012, 10:25 a.m., Matěj Laitl wrote: > > Yes, I definitly support this goal. By coincidence, this is very similar to > > what outlined in my mail. > > > > Ship it like this. I'd be even more glad if this could be somehow handled > > on the ServiceBrowser or Service class level in

Re: GSoC update from Riccardo - his KMail is b0rked again

On Mon, Aug 20, 2012 at 2:53 PM, Matěj Laitl wrote: > On 20. 8. 2012 Teo Mrnjavac wrote: >> http://wstaw.org/m/2012/08/20/plasma-desktopAH1228.png > > Good progress, but again I have to repeat myself: I will oppose merging any > rewrite that will introduce significant feature-loss regressions. Sor

Re: Review Request: {Smb, Nfs}DeviceHandler: use Solid instead of KMountPoint

d NFS is inaccessible as well. - Bart Cerneels On Aug. 19, 2012, 10:52 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

> On Aug. 17, 2012, 12:22 p.m., Ralf Engels wrote: > > I can only see the changed copyright header. > > Is this request still valid? Can we reject it? Ryan should probably close this one, rebase his gsoc branch and upload a new, full diff to a new review board. Want feedback from more people si

Amarok startup blocks when NFS mounts are not accessible

first on: NfsDeviceHandlerFactory::canHandle() NfsDeviceHandler.cpp:153 KMountPoint::Ptr m = KMountPoint::currentMountPoints().findByPath( access->filePath() ); Then after forcefully unmounting the shares, m is valid and canHandle() returns true, then it blocks on the next call to NfsDeviceHandl

[amarok] src: Fix typo in plugin query string. Missing space.

Git commit 66d5746e5086ac6667ebc8ad255cf6d6df9f6aab by Bart Cerneels. Committed on 16/08/2012 at 08:57. Pushed by shanachie into branch 'master'. Fix typo in plugin query string. Missing space. Not sure how/why this worked before. Can anyone familiar with KDE plugin explain. Are we eve

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

even I am using podcasting in Amarok except for development testing :/ - Bart Cerneels On Feb. 8, 2012, 11:15 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

/SpotifySettings.cpp <http://git.reviewboard.kde.org/r/105285/#comment13541> You probably should do readAll() here. The data will be fully available after finished(). Unless there is some platform specific reason to do it like this? - Bart Cerneels On Aug. 13, 2012, 11:24 a.m., Zhenglian

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 57 > > > > > > I'd rather you checked here, if m_controller is 0. Yup, can be

Re: [amarok/v2.6.0] src: Bump plugin version for the 2.6 release to 69

On Mon, Aug 13, 2012 at 1:14 PM, Matěj Laitl wrote: > Git commit 7350833639f56105c333d59eed1b821b3dfd06fb by Matěj Laitl. > Committed on 11/08/2012 at 11:07. > Pushed by laitl into tag 'v2.6.0'. > > Bump plugin version for the 2.6 release to 69 > > ...or, is it really needed to sing this song when

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

= NoError before continuing. In case of download error the write will still be attempted. - Bart Cerneels On Aug. 13, 2012, 11:24 a.m., Zhengliang Feng wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request: Fix crash when closing Amarok with running CoverFetcher

> On Aug. 9, 2012, 10:45 a.m., Matěj Laitl wrote: > > src/statusbar/CompoundProgressBar.cpp, line 46 > > > > > > Nitpicky: I would personally strip all the added newlines > > Ralf Engels wrote: > Actually I thin

Re: Review Request: Add playlist export action to Playlist Dock save action.

> On Aug. 8, 2012, 11:36 a.m., Bart Cerneels wrote: > > I wouldn't do this. Toolbars become less usable the more actions are in it. > > What is wrong with using the menu with a function that is not supposed to > > be used to often? > > Matěj Laitl wrote: >

Re: Review Request: Add playlist export action to Playlist Dock save action.

more actions are in it. What is wrong with using the menu with a function that is not supposed to be used to often? - Bart Cerneels On Aug. 2, 2012, 12:14 p.m., Ralf Engels wrote: > > --- > This is an automatically generated e-mail. T

Re: GSoC Report: Integrate Spotify into Amarok

On Tue, Jul 31, 2012 at 11:28 PM, Ryan Feng wrote: > Hi all, > >Last week I've been working on the configuration plug-in for > Spotify collection, and it's still working in progress. I have also > spent some time looking back at the SpotifyCollection and > SpotifyQueryMaker implementation, and

Re: Review Request: Multiple EngineController and related fixes, incl. fix for release_blocker bug 299890 (squashed commits, recent on top)

u did extensively anyway. Now go and roll 2.6 RC1 tarball or it will never happen! - Bart Cerneels On July 24, 2012, 4:07 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Moving Tab-toolbars to the top

I'm not in favor of changing the UI without a complete overhaul. I also would prefer if we avoided discussing design. On Wed, Jul 25, 2012 at 10:53 PM, Ralf Engels wrote: > Hi all, > > I noticed that our toolbars are all over the place. > The context and the playlist view have toolbars at the bot

Re: Review Request: EngineController: ditch canDecode(), fix supportedMimeTypes(): make it non-static, thread-safe even on first call. (squached patches, recent on top)

problems. - Bart Cerneels On July 19, 2012, 1:38 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: 2.6 release and release candidate considerations

On Wed, Jul 18, 2012 at 10:28 PM, Matěj Laitl wrote: > Hi list, Ralf & Bart, > after I've returned from a couple of days of off-line time, I've found out > that > Bart wants release a RC before releasing 2.6 - something I strongly support > given the severity of some post-beta changes. > > Howeve

Re: GSoC Report: Integrate Spotify into Amarok

On Sat, Jul 14, 2012 at 4:46 PM, Ryan Feng wrote: > Hi, > >The last report already showed that the Spotify plugin has been loaded > correctly and the collection is working, but sometimes the search results > are inserted into the collection but fail showing up in the collection, now > my next

Re: [amarok] src: EngineController: revive a part of Ralf's patch to fix 4 failing tests

I've got a patch ready that removes the codec install code in Amarok. It's since long ago been implemented in phonon. I was holding it off till post 2.6 because you never know what it might break non the less. Perhaps I should push it and release a second beta just tot test? On Sat, Jul 14, 2012

Re: GSoC update

On Fri, Jul 13, 2012 at 11:36 AM, Phalgun Guduthur wrote: > On Fri, Jul 13, 2012 at 1:02 PM, Bart Cerneels > wrote: >> >> On Wed, Jul 4, 2012 at 4:37 PM, Phalgun Guduthur >> wrote: >> > Hey All! >> > >> > An update on my GSoC project : Semantic

Re: [Tomahawk Integration] GSoC Report (plus: RFC on git work-flow guideline)

This command is mandatory for all amarok developers: git config branch.master.rebase true the result of this is that all "git pull" commands will do a rebase rather then a merge. Your local commits will be rewritten (parented to origin/master). The prevents the git log to become unreadable because

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

ttp://git.reviewboard.kde.org/r/105524/#comment12335> We should remove this canDecode() as well for the same reason I mention in the comment. - Bart Cerneels On July 12, 2012, 2:15 p.m., Matěj Laitl wrote: > > --- > This is an automatica

Re: GSoC update

On Wed, Jul 4, 2012 at 4:37 PM, Phalgun Guduthur wrote: > Hey All! > > An update on my GSoC project : Semantic Collection for Amarok > > I have figured out a way to reuse a lot of existing Amarok code. So it made > a part of the code I wrote till now redundant. > > I will be using MemoryCollection

spotify collection post mid-term TODO

* SpotifyCollection Object only created if Controller status is OK and general initialization workflow * Download resolver binary from kollide from settings dialog * Pass API key on build, shepherd changes into resolver repo. * Controller GPLv3 issue -> get an exception from Leo and Muesli or we'

Re: [Tomahawk Integration] GSoC Report

On Mon, Jul 9, 2012 at 11:15 PM, Lucas Lira Gomes wrote: > Hi everyone, > > i've been fixing bugs and improving overall performance of the tomahawk > service. It's a bit lazy to load big collections(50k tracks) and I haven't > figured yet how I can make its loading faster. And yes, I'm running tra

Re: NEW: Components list on our wiki

I added me as maintainer of CUE, CD and Podcasts. I'll be working on fixing major architectural problems for the first 2 and podcasts for historical reasons. On Sun, Jun 24, 2012 at 7:05 PM, Myriam Schweingruber wrote: > Hi everyone, > > I made a new wiki page that lists all our components with t

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

an whitespaces" in Text Editor > Behavior of the QtCreator settings. - Bart Cerneels On June 10, 2012, 7:10 a.m., Zhengliang Feng wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Unit test : ActionsCapability

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105144/#review14420 --- I'll need to test this before I'll hit ship i

Re: Review Request: Unit test : ActionsCapability

/r/105144/#comment11365> To verify this you could have created the capability with an empty list. Does not influence the test in any way. - Bart Cerneels On June 3, 2012, 3:45 p.m., Jasneet Bhatti wrote: > > --- > Thi

Re: GSoC update: Integrate Spotify into Amarok

On Sun, Jun 3, 2012 at 5:48 PM, Ryan Feng wrote: > On Sun, Jun 03, 2012 at 10:21:39AM +0200, Bart Cerneels wrote: >> Date: Sun, 3 Jun 2012 10:21:39 +0200 >> To: amarok-devel@kde.org >> Cc: Ryan Feng >> From: Bart Cerneels >> Subject: Re: GSoC update: Integrate

Re: GSoC update: Integrate Spotify into Amarok

On Sun, Jun 3, 2012 at 10:12 AM, Bart Cerneels wrote: > On Sun, Jun 3, 2012 at 6:32 AM, Ryan Feng wrote: >> Hi, >> >>    Last week I posted a scratch code of the Amarok side resolver, I'm >>    still working on it, like Leo and Bart said, there's no need t

Re: GSoC update: Integrate Spotify into Amarok

On Sun, Jun 3, 2012 at 10:12 AM, Bart Cerneels wrote: > On Sun, Jun 3, 2012 at 6:32 AM, Ryan Feng wrote: >> Hi, >> >>    Last week I posted a scratch code of the Amarok side resolver, I'm >>    still working on it, like Leo and Bart said, there's no need t

Re: GSoC update: Integrate Spotify into Amarok

On Sun, Jun 3, 2012 at 6:32 AM, Ryan Feng wrote: > Hi, > >    Last week I posted a scratch code of the Amarok side resolver, I'm >    still working on it, like Leo and Bart said, there's no need to >    change the standalone Spotify resolver, so I won't touch it for a >    time, and I added Spotif

Re: Amarok 2.5.90 does not build against KDE Platform Libraries 4.7.4

On Sun, Jun 3, 2012 at 12:05 AM, Modestas Vainius wrote: > Hello, > > On sekmadienis 03 Birželis 2012 00:21:31 Modestas Vainius wrote: >> cd ../doc/nl && /usr/bin/meinproc4 --check --cache >> /«PKGBUILDDIR»/obj-x86_64- linux-gnu/doc/nl/index.cache.bz2 >> /«PKGBUILDDIR»/doc/nl/index.docbook Unable

Re: Amarok 2.6 string freeze starting now!

On Wed, May 30, 2012 at 5:24 PM, Frederik Schwarzer wrote: > Am Mittwoch, 30. Mai 2012, 13:56:12 schrieb Bart Cerneels: >> Hi all >> >> We are in string freeze for release 2.6.0, the beta has been tagged >> (v.2.5.90). The final release (or next beta) is scheduled for t

[amarok] release_scripts: Update release HOWTO to current procedure.

Git commit e9bd850aac32bf30cefe16fd1b2cf9b0e0537818 by Bart Cerneels. Committed on 30/05/2012 at 14:05. Pushed by shanachie into branch 'master'. Update release HOWTO to current procedure. Don't be afraid to update and extent this people. Will make future tarball creators a lot

Amarok 2.6 string freeze starting now!

Hi all We are in string freeze for release 2.6.0, the beta has been tagged (v.2.5.90). The final release (or next beta) is scheduled for the weekend starting June 16. Bart ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/l

  1   2   3   4   >