Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

2013-10-21 Thread Alex Merry
- On Sept. 18, 2013, 7:34 p.m., Alex Busenius wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112802/ > --

Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

2013-09-20 Thread Alex Merry
> On Sept. 18, 2013, 9:46 p.m., Alex Merry wrote: > > I'm torn between following Amarok's internals (which you do) and following > > MPRIS2, meaning it should be called UserRating and return/allow a double > > between 0.0 and 1.0. > > > > There&#x

Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

2013-09-18 Thread Alex Merry
neral way of editing Metadata entries. - Alex Merry On Sept. 18, 2013, 7:34 p.m., Alex Busenius wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs

2013-07-15 Thread Alex Merry
the variables have changed. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111510/#review35988 --- On July 15, 2013, 1:18 p.

Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs

2013-07-15 Thread Alex Merry
/diff/ Testing --- Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5. No other configurations tested. (Without the patch, the build fails with this configuration). Thanks, Alex Merry ___ Amarok-devel mailing list Amarok-

Re: Review Request 111512: MPRIS2: avoid updating Metadata when between tracks

2013-07-15 Thread Alex Merry
t;" -> "/org/kde/amarok/Track/8264712350997591513" when I manually change the track (eg: by clicking "next" or by double-clicking another track). With the patch, I only get things like Track change: "/org/kde/amarok/Track/5739423209746661216" -> "/or

Review Request 111512: MPRIS2: avoid updating Metadata when between tracks

2013-07-14 Thread Alex Merry
y double-clicking another track). With the patch, I only get things like Track change: "/org/kde/amarok/Track/5739423209746661216" -> "/org/kde/amarok/Track/8264712350997591513" Thanks, Alex Merry ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Alex Merry
x27;s Device Notifier. This made an item corresponding to it appear in the "Local Music" pane of Amarok. Unmounting it by the same method made it go away again. - Alex Merry On June 11, 2012, 3:14 p.m., Matěj Laitl wrote: > > ---

Fwd: Our research tool has generated a FAQ for Amarok

2011-09-22 Thread Alex Merry
om To: Alex Merry Dear Mr. Merry, Our team at the University of Darmstadt (Germany) has created a tool which generates FAQs from mailing lists and forums using data mining techniques. We have generated a FAQ for your project and would like to have your opinion on it. Within approx. 10 minutes

Review Request: Auto-save the playlist so it is not lost if Amarok crashes

2011-08-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102444/ --- Review request for Amarok. Summary --- One of the things that bugs me

Re: Review Request: Use KImageCache if possible, rather than KPixmapCache

2011-05-15 Thread Alex Merry
http://git.reviewboard.kde.org/r/101347/#review3313 --- On May 12, 2011, 11:52 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request: Use KImageCache if possible, rather than KPixmapCache

2011-05-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101347/ --- Review request for Amarok. Summary --- KPixmapCache is horribly buggy

Re: Fix for MySQL embedded permissions error on upgrading to MySQL 5.5

2011-03-20 Thread Alex Merry
Isn't this what Ian's eean-mysql5.5.9fix branch fixes? Alex On 20/03/11 17:45, Nikhil Marathe wrote: > Hi, > > If any user/developer updates to MySQL 5.5 (for example Archlinux now > has 5.5.9), there is a bug in the MySQL build > which stops MYSQL_HOME from being treated as the directory to se

Re: mysql 5.5 may require mysql_upgrade

2011-03-11 Thread Alex Merry
Your branch works for me (with mysql 5.5.9), but I didn't have to (and never have) run mysql_upgrade. Alex On 06/03/11 02:47, Ian Monroe wrote: > First off mysql 5.5 apparently ignores the MYSQL_HOME, which is > disappointing. The branch eean-mysql5.5.9fix addresses this. > > I had to run mysq

Re: Review Request: Coverbling applet (playground) build fix

2010-11-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/#review302 --- Ship it! Looks good (modulo my code style comment below). play

Re: Review Request: Coverbling applet (playground) build fix

2010-11-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/#review292 --- playground/src/context/applets/coverbling/CoverBlingApplet.cpp <

Re: Review Request: Remove EngineObserver and replacing it with signals/slots for better thread safety

2010-11-02 Thread Alex Merry
> On 2010-10-31 20:14:08, Alex Merry wrote: > > src/EngineController.h, line 350 > > <http://git.reviewboard.kde.org/r/100120/diff/1/?file=2895#file2895line350> > > > > But not when it resumes, right? This should be clarified in the docs. > > Ralf

Re: Review Request: Remove EngineObserver and replacing it with signals/slots for better thread safety

2010-11-01 Thread Alex Merry
> On 2010-10-31 20:14:08, Alex Merry wrote: > > src/EngineController.h, line 117 > > <http://git.reviewboard.kde.org/r/100120/diff/1/?file=2895#file2895line117> > > > > Delete stuff rather than commenting it :-) > > Ralf Engels wrote: > It was u