----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112802/#review40313 -----------------------------------------------------------
I'm torn between following Amarok's internals (which you do) and following MPRIS2, meaning it should be called UserRating and return/allow a double between 0.0 and 1.0. There's also the question of how urgent this is, as there's discussion on the MPRIS list (which had stalled for a few months, but I started up again) about adding a general way of editing Metadata entries. - Alex Merry On Sept. 18, 2013, 7:34 p.m., Alex Busenius wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112802/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 7:34 p.m.) > > > Review request for Amarok and Alex Merry. > > > Description > ------- > > The D-Bus interface is currently missing convenient method for reading and > setting user rating (the stars). The proposed patch adds an Mpris2 extension > to /org/mpris/MediaPlayer2 for that: > > property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating > > > Diffs > ----- > > src/dbus/mpris2/MediaPlayer2AmarokExtensions.h 964c7b8 > src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp ba8b54e > src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml 3397df4 > > Diff: http://git.reviewboard.kde.org/r/112802/diff/ > > > Testing > ------- > > > Thanks, > > Alex Busenius > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
