D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

2020-06-17 Thread Malte Veerman
malteveerman added inline comments. INLINE COMMENTS > wbauer wrote in FindMySQLe.cmake:45 > > Although, I just noticed that it actually does that below (in line#73ff) if > > (NOT MYSQLE_LIBRARIES), so maybe it would just be enough to remove the > > set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) here

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

2020-06-17 Thread Wolfgang Bauer
wbauer added inline comments. INLINE COMMENTS > wbauer wrote in FindMySQLe.cmake:45 > Right, that's exactly what I was referring to in my last comment, and what > the openSUSE patch I mentioned (which originally was taken from Arch) is > supposed to fix. > > I.e. instead of `set(MYSQLE_LIBRARI

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

2020-06-17 Thread Wolfgang Bauer
wbauer added inline comments. INLINE COMMENTS > malteveerman wrote in FindMySQLe.cmake:45 > This breaks embedded for me. The embedded storage plugin silently links > against libmysqlclient and then fails when initializing. > It's a problem that exists independently of this revision but I thought