malteveerman added inline comments.
INLINE COMMENTS
> wbauer wrote in FindMySQLe.cmake:45
> > Although, I just noticed that it actually does that below (in line#73ff) if
> > (NOT MYSQLE_LIBRARIES), so maybe it would just be enough to remove the
> > set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) here completely?
>
> Indeed, it works fine for me (without any additional patch) if I remove that
> `set (MYSQLE_LIBRARIES ${MYSQL_LIBRARIES})` line.
>
> As this if branch is empty then (except for the comments, it would probably
> be more readable to remove the whole branch and invert the `if` condition.
> Actually I think just `if ("${MC_return_embedded}" STREQUAL "0")` should be
> enough then, at least that works here on openSUSE too. And probably is more
> correct as well.
Works for me as well.
REPOSITORY
R181 Amarok
BRANCH
mysqle-split-for-phab
REVISION DETAIL
https://phabricator.kde.org/D28284
To: asturmlechner, #amarok, heikobecker, wbauer
Cc: malteveerman, amarok-devel, vmatare, mdn, pgomes, nicolamori, jyasi,
mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman,
paul, domson, yaohanchen, markey, James, tbettler, Smar, ricktimmis,
asturmlechner, schweingruber, heikobecker
