Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39923 --- Ship it! Ship it! (and no, I think HTTPS should be the default

Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- Review request for Amarok. Description --- Allow to use wikipedia ove

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
> On Sept. 12, 2013, 9:04 p.m., Matěj Laitl wrote: > > Ship it! (and no, I think HTTPS should be the default, let's heat those NSA > > supercomputers a bit. I have to recall this patch. I noticed that there is still some HTTP traffic. I will look into it tomorrow. - Frank -

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 12, 2013, 9:20 p.m.) Status -- This change has been di

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39920 --- Looks good to me (with a few style comments). Please don't forg

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 12, 2013, 8:44 p.m.) Review request for Amarok. Changes -

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
> On Sept. 12, 2013, 8:17 p.m., Matěj Laitl wrote: > > Looks good to me (with a few style comments). Please don't forget to add > > BUG, FIXED-IN tags and ChangeLog entry when comitting. > > > > The only reason why we should not hard-code https is that it is blocked by > > in some circumstance

Re: Added support for Visualizations using VSXu

2013-09-12 Thread Dinesh
Hey Konrad, We have merged the Amarok Fixes branch into VSXu master. And the patch for the problem with the FindVSXu.cmake is in VSXu master now. (It was a broken libvsxu.pc file). As for the blank visualizer applet, I still cannot reproduce the problem on my machine. But I have pushed one more