Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

2013-07-31 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111824/ --- (Updated July 31, 2013, 6:22 p.m.) Review request for Amarok. Descriptio

Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

2013-07-31 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111824/ --- (Updated July 31, 2013, 6:22 p.m.) Review request for Amarok. Descriptio

Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

2013-07-31 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111824/ --- Review request for Amarok. Description --- I created a new runnable c

Need a mentor for an SoK idea

2013-07-31 Thread vedant agarwala
Hello, I have a idea for SoK: Improved Lyrics fetching and display. As of now Amarok uses a script to download lyrics from lyricwiki.org. It would be a better idea to make this an integral part of Amarok. Then, we can add more web services to download lyrics (like minilyrics). The lyrics display al

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36868 --- Ship it! Ship It! - Konrad Zemek On July 31, 2013, 11:59 a.

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- (Updated July 31, 2013, 11:59 a.m.) Review request for Amarok. Changes -

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36867 --- src/playlist/PlaylistSortWidget.cpp

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Fabian Kosmale
> On July 30, 2013, 10:04 p.m., Edward Hades Toroshchin wrote: > > src/playlist/PlaylistSortWidget.cpp, line 73 > > > > > > If the sort token has neither "asc" nor "des" suffix, it won't be added > > to the sort a

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- (Updated July 31, 2013, 9:47 a.m.) Review request for Amarok. Changes --