----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36867 -----------------------------------------------------------
src/playlist/PlaylistSortWidget.cpp <http://git.reviewboard.kde.org/r/111804/#comment27190> This "if" needs to be an "else if", otherwise a warning will be issued for invalid level, and then Amarok will crash regardless. - Konrad Zemek On July 31, 2013, 9:47 a.m., Fabian Kosmale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111804/ > ----------------------------------------------------------- > > (Updated July 31, 2013, 9:47 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Without this patch, Amarok would crash with > ASSERT failure in QList<T>::at: "index out of range" > when amarokrc contained > [Playlist Sorting] > SortPath=Shuffle > > > Diffs > ----- > > src/playlist/PlaylistSortWidget.cpp > 384e4a0eaa28f82eb27665a1a0d497e018a61161 > > Diff: http://git.reviewboard.kde.org/r/111804/diff/ > > > Testing > ------- > > Compiled and started Amarok. It doesn't crash anymore. > > > Thanks, > > Fabian Kosmale > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
