Re: Review Request 109758: Asx playlist implementation.

2013-04-06 Thread Tatjana Gornak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/ --- (Updated April 7, 2013, 2:54 a.m.) Review request for Amarok. Descriptio

Re: Review Request 109879: Small cleanups in playlists

2013-04-06 Thread Tatjana Gornak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109879/ --- (Updated April 7, 2013, 2:27 a.m.) Review request for Amarok. Descriptio

[amarok] /: Formatting fixes to ChangeLog (only 2.8-Beta entry)

2013-04-06 Thread Matěj Laitl
Git commit 6a4bebbe80c8237588cf2dbed1c6f329aa58f537 by Matěj Laitl. Committed on 06/04/2013 at 18:52. Pushed by laitl into branch 'master'. Formatting fixes to ChangeLog (only 2.8-Beta entry) Not a big deal of course, bug 70-char long lines felt bad to my eyes. :-) I propose we should follow fol

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-06 Thread Anmol Ahuja
> On April 4, 2013, 3:41 a.m., Matěj Laitl wrote: > > src/core/transcoding/TranscodingConfiguration.h, line 61 > > > > > > You've introduced and enum, why do you accept an int? Also please > > rename transConfig t

Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

2013-04-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109846/ --- (Updated April 6, 2013, 4:13 p.m.) Status -- This change has been mar

Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

2013-04-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109846/#review30570 --- This review has been submitted with commit 71e55e7bdd9b31642d0

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-06 Thread Matěj Laitl
> On April 3, 2013, 10:11 p.m., Matěj Laitl wrote: > > src/core/transcoding/TranscodingConfiguration.h, line 61 > > > > > > You've introduced and enum, why do you accept an int? Also please > > rename transConfig

Re: Review Request 109879: Small cleanups in playlists

2013-04-06 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109879/#review30552 --- Thanks, we just love code deduplication & cleanups. :-) I have

Fwd: Re: Radio GFM integration in Amarok by default

2013-04-06 Thread Matěj Laitl
[Forwarding to ama...@kde.org; Marco, it is usual to keep all original addressees in CC:] -- Forwarded Message -- Subject: Re: Radio GFM integration in Amarok by default Date: Saturday 06 of April 2013, 12:51:01 From: Marco Peter To: Matěj Laitl CC: Gregor Atzbach Hi Matěj!

Re: Review Request 100176: Fetch cover for DAAP Albums #240060

2013-04-06 Thread Matěj Laitl
> On April 5, 2013, 8:33 p.m., Albert Astals Cid wrote: > > If this doesn't get any action before my next janitorial round I'll discard > > the Review Request understanding nooone cares enough to push this forward. Looking at the code, this seems still valuable for Amarok. I'll try to get some