----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109846/#review30570 -----------------------------------------------------------
This review has been submitted with commit 71e55e7bdd9b31642d09145a5801777c0e120454 by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On April 5, 2013, 6:31 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109846/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 6:31 p.m.) > > > Review request for Amarok and Oliver Henshaw. > > > Description > ------- > > 1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options: > Pause playback on suspend > Inhibit suspend if playing > 2. Created a PowerManager class to handle suspend behavior > > Fixes: > BR 259862 - Amarok does not inhibit suspend while playing > BR 222571 - Amarok pause on suspend > > > Diffs > ----- > > src/playback/PowerManager.h PRE-CREATION > src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 > src/amarokconfig.kcfg fbe5497 > src/EngineController.cpp 52bfd90 > ChangeLog 3422cad > src/CMakeLists.txt 990f313 > src/playback/PowerManager.cpp PRE-CREATION > tests/core-impl/meta/multi/CMakeLists.txt 327b555 > tests/playlist/CMakeLists.txt c2e4c06 > > Diff: http://git.reviewboard.kde.org/r/109846/diff/ > > > Testing > ------- > > Works as expected > > > File Attachments > ---------------- > > PlaybackConfig Dialog > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
