Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review29971 --- Hmmm, I'm apparently able to update the diff, please disregard

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/ --- (Updated March 27, 2013, 7:35 p.m.) Review request for Amarok. Changes -

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109470/ --- (Updated March 27, 2013, 7:22 p.m.) Review request for Amarok. Changes -

Re: Review Request 107473: Changes in processing playlist files

> On March 27, 2013, 12:35 p.m., Matěj Laitl wrote: > > src/core-impl/playlists/types/file/m3u/M3UPlaylist.h, lines 49-52 > > > > > > Private? Should be "protected". > > Tatjana Gornak wrote: > Sorry, origi

Re: Review Request 107473: Changes in processing playlist files

> On March 27, 2013, 12:35 p.m., Matěj Laitl wrote: > > src/core-impl/playlists/types/file/m3u/M3UPlaylist.h, lines 49-52 > > > > > > Private? Should be "protected". Sorry, originally I've planned to make Playl

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/ --- (Updated March 27, 2013, 3:41 p.m.) Review request for Amarok. Changes -

Re: Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108906/ --- (Updated March 27, 2013, 2:45 p.m.) Status -- This change has been di

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review29959 --- Looks good, thanks! Just a remark or 2 below. Thanks also for t

Re: Review Request 109758: Asx playlist implementation.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/#review29958 --- Hi, looks good & clean (thanks to your previous cleanups), just

Re: Review Request 109752: JJ 316128: Handle Data CDs in Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109752/#review29956 --- Looks rather good, please resolve minor issues below. Also plea

Re: Review Request 109695: JJ#241066: Added a prepareToQuit() signal to amarokWindowScript

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109695/#review29953 --- Looks good, just please resolve the remarks and please add entr

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109470/#review29952 --- Review Board says you've uploaded a malformed patch, please fix

Re: Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109224/ --- (Updated March 27, 2013, 1:16 p.m.) Status -- This change has been di

Re: Review Request 109585: FIX UI doesn't say I have to run Moodbar generator manually. (BR 289483)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109585/#review29951 --- Nice change, thanks. Kudos for including the ChangeLog entry. J

Re: Review Request 107473: Changes in processing playlist files

> On March 27, 2013, 12:35 p.m., Matěj Laitl wrote: > > Yeah, nice change, you go even further with code deduplication. I have a > > load of changes that should be applied on top of your patch (which will > > include fixes to issues below), please wait for it along with some comments. You also

Jenkins build is back to normal : amarok_master #308

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review29948 --- Yeah, nice change, you go even further with code deduplication.

Build failed in Jenkins: amarok_master #307

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 3085 lines...] from /srv/jenkins/install/linux/x64_64/g++/common/shared/include/gmock/gmock-actions.h:46