----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109585/#review29951 -----------------------------------------------------------
Nice change, thanks. Kudos for including the ChangeLog entry. Just please do the minor tweaks and this will be "Ship It!" ChangeLog <http://git.reviewboard.kde.org/r/109585/#comment22320> ChangeLog entries are added on top of the relevant categories. (please rebase your patch on top of current git master first) src/configdialog/dialogs/GeneralConfig.ui <http://git.reviewboard.kde.org/r/109585/#comment22319> I don't think this needs mouseTracking, please revert it to its default state using Qt Designer. src/configdialog/dialogs/GeneralConfig.ui <http://git.reviewboard.kde.org/r/109585/#comment22318> Just please make the link text '... visit <a href="...">related article on KDE UserBase</a>.' - Matěj Laitl On March 19, 2013, 5:58 p.m., Harsh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109585/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 5:58 p.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Description > ------- > > Added a label in moodbar options saying moodbar files must be generated > manually. > > > This addresses bug 289483. > https://bugs.kde.org/show_bug.cgi?id=289483 > > > Diffs > ----- > > ChangeLog 284f188 > src/configdialog/dialogs/GeneralConfig.ui 4e33f64 > > Diff: http://git.reviewboard.kde.org/r/109585/diff/ > > > Testing > ------- > > All test case passed. > > > File Attachments > ---------------- > > Screenshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png > > > Thanks, > > Harsh Gupta > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
