Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109283/#review28566 --- Hi. All sorts of things going on here. My biggest question is

Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

> On March 5, 2013, 1:41 a.m., Dan Meltzer wrote: > > src/statsyncing/ScrobblingService.h, line 54 > > > > > > Is this really a Scrobbling Error? Seems like a hack to me It is a hack, like the other "errors" in t

Re: Review Request 107473: Changes in processing playlist files

> On March 5, 2013, 12:11 a.m., Matěj Laitl wrote: > > src/DirectoryLoader.cpp, lines 168-169 > > > > > > Here you would have to deal with both async-loading and sync-loading > > playlists (you don't want to add

Re: Review Request 107473: Changes in processing playlist files

> On March 5, 2013, 12:11 a.m., Matěj Laitl wrote: > > Tatjana, thanks for your continued effort on this review. :-) There seem to > > be a couple of problematic places that may cause regressions, please take a > > look at them so this can be merged. (which I hope can be done rather soon, > >

Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109283/ --- Review request for Amarok. Description --- Added a check-box to disab

Re: Review Request 109157: Amarok buildsystem cleanup preview

> On Feb. 25, 2013, 9:48 p.m., Edward Hades Toroshchin wrote: > > Why do you want the intermediate libs at all? > > Matěj Laitl wrote: > In general, all points mentioned in > http://www.cmake.org/Wiki/CMake/Tutorials/Object_Library#Motivation hold > here, especially "This approach is easy