> On March 5, 2013, 1:41 a.m., Dan Meltzer wrote: > > src/statsyncing/ScrobblingService.h, line 54 > > <http://git.reviewboard.kde.org/r/109283/diff/1/?file=116987#file116987line54> > > > > Is this really a Scrobbling Error? Seems like a hack to me
It is a hack, like the other "errors" in the enum (TooShort, BadMetaData, FromTheFuture) Actaully, only NoError and FromTheDistantPast are of use to the last.fm scrobbling service > On March 5, 2013, 1:41 a.m., Dan Meltzer wrote: > > src/services/lastfm/ScrobblerAdapter.cpp, line 280 > > <http://git.reviewboard.kde.org/r/109283/diff/1/?file=116985#file116985line280> > > > > Is it your intention to only allow one label to be skipped for > > scrobbling? If so, why? Shouldn't it be a list of banned labels that we > > are comparing against? I used the QComboBox as per Matej's comment (#21) in https://bugs.kde.org/show_bug.cgi?id=140198 If needed I can easily change it to a QListWidget, that will resolve this issue. - Vedant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109283/#review28566 ----------------------------------------------------------- On March 4, 2013, 7:31 p.m., Vedant Agarwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109283/ > ----------------------------------------------------------- > > (Updated March 4, 2013, 7:31 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Added a check-box to disable scobbling for tracks with a particular label. > The label can be selected from a drop-down list or entered manually. Any > track that contains this label is skipped from being submitted to last.fm for > being scrobbled. > > > Diffs > ----- > > src/core/collections/QueryMaker.h a30b94f > src/services/lastfm/LastFmConfigWidget.ui 5c5e51b > src/services/lastfm/LastFmServiceConfig.h 3f33b72 > src/services/lastfm/LastFmServiceSettings.h 41b2ead > src/services/lastfm/LastFmServiceSettings.cpp f6e1564 > src/services/lastfm/ScrobblerAdapter.h ea74196 > src/services/lastfm/ScrobblerAdapter.cpp b1a09f8 > src/statsyncing/Process.cpp c42fdc4 > src/statsyncing/ScrobblingService.h 971edd7 > > Diff: http://git.reviewboard.kde.org/r/109283/diff/ > > > Testing > ------- > > Builds and runs successfully. > > > Thanks, > > Vedant Agarwala > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
