Re: TODO for 2.7: android MTP

2012-09-10 Thread Bart Cerneels
On Mon, Sep 10, 2012 at 9:56 PM, Philipp Schmidt wrote: > Am Montag, 10. September 2012, 17:06:57 schrieb Matěj Laitl: >> On 10. 9. 2012 Bart Cerneels wrote: >> > Having recently bought a Galaxy 3 I can confirm, we need have very >> > good MTP support i.e. rewrite MtpCollection. >> > >> > For anyo

[KDE Bugtracking System] Release blockers

2012-09-10 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 230991: https://bugs.kde.org/show_bug.cgi?id=230991 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary:

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-10 Thread Mathias Stephan Panzenböck
On Sept. 10, 2012, 10:09 a.m., Mathias Stephan Panzenböck wrote: > > Also please: > > * add REVIEW:, DIGEST: entries to the commit message (description here) > > so that is can be used in commit directly. See > > https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/raw/.c

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-10 Thread Mathias Stephan Panzenböck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/ --- (Updated Sept. 11, 2012, 12:38 a.m.) Review request for Amarok. Descript

Re: TODO for 2.7: android MTP

2012-09-10 Thread Philipp Schmidt
Am Montag, 10. September 2012, 17:06:57 schrieb Matěj Laitl: > On 10. 9. 2012 Bart Cerneels wrote: > > Having recently bought a Galaxy 3 I can confirm, we need have very > > good MTP support i.e. rewrite MtpCollection. > > > > For anyone taking it on (/me looks in the general direction of > > stro

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-09-10 Thread Phalgun Guduthur
> On Sept. 4, 2012, 6:11 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp, > > line 167 > > > > > > length is int, why you use toDouble() for it? (same applies to

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-09-10 Thread Phalgun Guduthur
> On Sept. 4, 2012, 6:11 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp, > > line 260 > > > > > > Does MemoryMeta handle labels right? So I should be duplicati

Re: TODO for 2.7: android MTP

2012-09-10 Thread Matěj Laitl
On 10. 9. 2012 Bart Cerneels wrote: > Having recently bought a Galaxy 3 I can confirm, we need have very > good MTP support i.e. rewrite MtpCollection. > > For anyone taking it on (/me looks in the general direction of > strohel) I might have a device you can use. Yeah, I've thought about it. MTP

Re: API proposal: Phonon BackendInfo

2012-09-10 Thread Bart Cerneels
On Sun, Sep 9, 2012 at 3:04 PM, Harald Sitter wrote: > On Sun, Sep 9, 2012 at 2:14 PM, Matěj Laitl wrote: >>> /** @returns \c true when this backend was provided by a platform plugin >>> */ >>> bool isPlatformProvided() const; >> >> Perhaps this has sense to people who known how Phono

TODO for 2.7: android MTP

2012-09-10 Thread Bart Cerneels
http://amarok.kde.org/en/releases/2.6#comment-14114 Having recently bought a Galaxy 3 I can confirm, we need have very good MTP support i.e. rewrite MtpCollection. For anyone taking it on (/me looks in the general direction of strohel) I might have a device you can use. Bart

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-09-10 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review18786 --- Ship it! Looks good to me, let's ship this with minor modifica

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

2012-09-10 Thread Bart Cerneels
> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote: > > There are some welcome changes in this patch: > > * ability to implement statistics by inheritance > > * StatisticsCapability removal > > > > However, there are some things I dislike: > > * Meta::Track inheriting AbstractStatistics > > *