----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review18786 -----------------------------------------------------------
Ship it! Looks good to me, let's ship this with minor modifications. ChangeLog <http://git.reviewboard.kde.org/r/101598/#comment14901> Please move to 2.7 section Also please: * add REVIEW:, DIGEST: entries to the commit message (description here) so that is can be used in commit directly. See https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/raw/.commit-template * locate TagLib in README and add note that compiling against 1.8 adds support for the formats * are there any Amarok bugs that can be closed by this? - Matěj Laitl On Sept. 9, 2012, 4:53 p.m., Mathias Stephan Panzenböck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101598/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2012, 4:53 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This patch adds read/write tag support for mod, s3m, it and xm files if > taglib supports it. All new parts are #ifdefed so it won't break if an old > taglib version is used. > > I wrote a patch for taglib that enables support for these file formats and it > will be included in taglib 1.8.0. Here is the pull request: > https://github.com/taglib/taglib/pull/4 > > Update: > TagLib 1.8 is released and includes my mod, s3m, it and xm patches: > http://taglib.github.com/ > > > This addresses bug 90524. > https://bugs.kde.org/show_bug.cgi?id=90524 > > > Diffs > ----- > > CMakeLists.txt ebb8064 > ChangeLog 1294109 > config-amarok.h.cmake 2d25cc7 > shared/FileType.h 3c11ed0 > shared/FileType.cpp 23aee04 > shared/FileTypeResolver.cpp e69a514 > shared/tag_helpers/TagHelper.cpp 3365432 > > Diff: http://git.reviewboard.kde.org/r/101598/diff/ > > > Testing > ------- > > > Thanks, > > Mathias Stephan Panzenböck > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
