> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote:
> > There are some welcome changes in this patch:
> > * ability to implement statistics by inheritance
> > * StatisticsCapability removal
> >
> > However, there are some things I dislike:
> > * Meta::Track inheriting AbstractStatistics
> > *
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/#review18778
---
Normally uidUrl() should be used. It's a bug we'll have to look
> On Sept. 9, 2012, 5:15 p.m., Matěj Laitl wrote:
> > Good. I think that is has sense for Amarok 2.7 to depend on TagLib 1.8,
> > let's see what other devs think.
This patch doesn't make Amarok dependent on TagLib 1.8. Everything is #ifdef-ed
so it compiles with older versions of TagLib.
- M
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/#review18741
---
Good. I think that is has sense for Amarok 2.7 to depend on Tag
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/
---
(Updated Sept. 9, 2012, 4:53 p.m.)
Review request for Amarok.
Descriptio
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/
---
(Updated Sept. 9, 2012, 4:43 p.m.)
Review request for Amarok.
Changes
--
> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote:
> > There are some welcome changes in this patch:
> > * ability to implement statistics by inheritance
> > * StatisticsCapability removal
> >
> > However, there are some things I dislike:
> > * Meta::Track inheriting AbstractStatistics
> > *
On Sun, Sep 9, 2012 at 2:14 PM, Matěj Laitl wrote:
>> /** @returns \c true when this backend was provided by a platform plugin
>> */
>> bool isPlatformProvided() const;
>
> Perhaps this has sense to people who known how Phonon is implemented in Qt,
> but I don't understand what "provid
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105629/#review18716
---
Good work, I see you tests have oncovered a couple of our error
> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote:
> > There are some welcome changes in this patch:
> > * ability to implement statistics by inheritance
> > * StatisticsCapability removal
> >
> > However, there are some things I dislike:
> > * Meta::Track inheriting AbstractStatistics
> > *
On 9. 9. 2012 Harald Sitter wrote:
> attached is a proposed api for phonon backend information as both
> amarok and tomahawk have diagnostics functionality that needs accurate
> information on the loaded backend. this addition would would address
> [1].
>
> feedback would be much appreciated.
>
>
> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote:
> > There are some welcome changes in this patch:
> > * ability to implement statistics by inheritance
> > * StatisticsCapability removal
> >
> > However, there are some things I dislike:
> > * Meta::Track inheriting AbstractStatistics
> > *
ahoyahoy
attached is a proposed api for phonon backend information as both
amarok and tomahawk have diagnostics functionality that needs accurate
information on the loaded backend. this addition would would address
[1].
feedback would be much appreciated.
implementation-wise this is a no-brainer
> On Sept. 9, 2012, 10:22 a.m., Matěj Laitl wrote:
> > There are some welcome changes in this patch:
> > * ability to implement statistics by inheritance
> > * StatisticsCapability removal
> >
> > However, there are some things I dislike:
> > * Meta::Track inheriting AbstractStatistics
> > *
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106276/#review18709
---
There are some welcome changes in this patch:
* ability to imp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/
---
(Updated Sept. 8, 2012, 7:11 p.m.)
Review request for Amarok.
Changes
--
16 matches
Mail list logo
