----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106366/ -----------------------------------------------------------
(Updated Sept. 8, 2012, 7:11 p.m.) Review request for Amarok. Changes ------- Implement TrackProvider::possiblyContainesTrack and TrackProvider::trackForUrl for the DaapCollection. This in theory fixes resuming play after an Amarok restart. In practice apparently the playableUrl is restored from the playlist and passed to the CollectionManager for restoring. As the playable url starts with http:// this is handled as a HttpStream and never will reach a DaapCollection. Removing the check for http in the CollectionManager::trackForUrl method leads to the desired behavior but, of course, breaks other stuff. I still did so in this patch for demonstration purposes. If possible the uidUrl should be used when calling trackForUrl, but i am sure good reasons exist for not doing so... P.S.: I wont be able to work on this until at least Thursday, as I am in an untrusted network right now. Description ------- This simply sends a fake revision-number to the server. Also appends the session-id field to the track URLs. See: https://bugs.kde.org/show_bug.cgi?id=306351 See: https://bugs.kde.org/show_bug.cgi?id=306351 Diffs (updated) ----- src/core-impl/collections/daap/DaapCollection.h f8655ec src/core-impl/collections/daap/DaapCollection.cpp 5d1bd9b src/core-impl/collections/daap/DaapMeta.h 5278b57 src/core-impl/collections/daap/DaapMeta.cpp a2429d7 src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 src/core-impl/collections/support/CollectionManager.cpp d196403 Diff: http://git.reviewboard.kde.org/r/106366/diff/ Testing ------- - Rhythmbox collections now correctly appear and play in Amarok. - Validated that mt-daap collections are still working. Thanks, Daniel Stöckel
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
