Re: Review Request: Restore heuristics to guess whether album is a compilation

> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote: > > Just going through all the review requests again. > > > > With your patch the following auto test is failing: > > testIdentifyCompilationInMultipleDirectories > > Alexey Neyman wrote: > Which is, I guess, expected - since it was the pu

Re: Review Request: GSoC : Nepomuk plugin for Amarok

> On Aug. 15, 2012, 5:23 p.m., Matěj Laitl wrote: > > src/core-impl/collections/support/MemoryMeta.cpp, line 148 > > > > > > Good. Please have this change as a separate commit (perhaps it already > > is, I haven't

Re: Review Request: Remove obsolete dependancies from playground

> On Aug. 18, 2012, 10:17 a.m., Matěj Laitl wrote: > > Ship it! Just to be sure, your testing "the code compiles" was with > > ENABLE_PLAYGROUND enabled, right? Do you heve developer status on > > identity.k.o to commit yourself? Yes I did compile it with ENABLE_PLAYGROUND, this patch is actua

Build failed in Jenkins: amarok_master #237

See Changes: [edward.hades] improve temporary file handling [edward.hades] magnatune: remove memleak in xml parser -- [...truncated 4132 lines...] Linking CXX shared module ../../../../lib/amarok_contex

Re: Review Request: GSoC : Nepomuk plugin for Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ --- (Updated Aug. 18, 2012, 5:58 p.m.) Review request for Amarok, Edward Hades

Build failed in Jenkins: amarok_master #238

See Changes: [edward.hades] magnatune: flush database after commit [edward.hades] magnatune: added "auto update database" option [edward.hades] magnatune: honor auto update settings [edward.hades] magnatune: ask user to update database

Re: Review Request: magnatune: first update related tweaks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106071/#review17658 --- This review has been submitted with commit c337d5ac20ff8c1989e

Build failed in Jenkins: amarok_master #236

See Changes: [edward.hades] Reasonable default settings for .reviewboardrc [edward.hades] magnatune: reword update message -- [...truncated 4112 lines...] [ 83%] Building CXX object src/core-impl/colle

Re: Review Request: GSoC : Nepomuk plugin for Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/#review17660 --- Ship it! Can't see anything wrong with this. Good job! Ship

Re: Review Request: magnatune: first update related tweaks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106071/#review17651 --- Ship it! Yes, I definitly support this goal. By coincidence, t

Re: Review Request: Remove obsolete dependancies from playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106067/#review17649 --- Ship it! Ship it! Just to be sure, your testing "the code comp

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

On 17. 8. 2012 Edward Toroshchin wrote: > > Don't take it personally, but if you don't revert I'm going to. > > Don't take it personally, but I believe you need at least someone else > to back you up on this to revert anything. Currently, no one except us > has expressed their point of view :). M

Review Request: magnatune: first update related tweaks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106071/ --- Review request for Amarok. Description --- magnatune: first update re