Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( AlbumKey )

> On July 13, 2012, 1:03 p.m., Matěj Laitl wrote: > > tests/core/meta/support/TestMetaAlbumKey.cpp, line 33 > > > > > > How big are the added files? They should be no more than a few > > kilobytes in order not to ma

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( AlbumKey )

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105497/ --- (Updated July 14, 2012, 6:03 a.m.) Review request for Amarok, Matěj Laitl

[KDE Bugtracking System] REMINDER: current Amarok regressions

Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions -- Bug 230991: https://bugs.kde.org/show_bug.cgi?id=230991 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-b

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( TrackKey )

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105454/ --- (Updated July 14, 2012, 4:06 a.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( TrackKey )

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105454/#review15796 --- tests/core/meta/support/TestMetaTrackKey.cpp

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( AlbumKey )

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105497/#review15794 --- tests/core/meta/support/TestMetaAlbumKey.h

Re: Review Request: SoK - Unit Test : core/meta/support/MetaKeys( TrackKey )

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105454/#review15792 --- Looks good, please add one more test method. tests/core/meta/

Re: Review Request: EngineController: ditch canDecode(), fix supportedMimeTypes(): make it non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/ --- (Updated July 13, 2012, 12:07 p.m.) Review request for Amarok, Ralf Engels

Re: Review Request: EngineController: ditch canDecode(), fix supportedMimeTypes(): make it non-static, thread-safe even on first call. (squached patches, recent on top)

> On July 12, 2012, 11:04 p.m., Ralf Engels wrote: > > tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp, line 77 > > > > > > If we need to have special code here to ensure a sensible cleanup, > > might w

Re: Review Request: EngineController: ditch canDecode(), fix supportedMimeTypes(): make it non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/ --- (Updated July 13, 2012, 11:53 a.m.) Review request for Amarok, Ralf Engels

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

> On July 13, 2012, 7:55 a.m., Bart Cerneels wrote: > > src/browsers/filebrowser/FileView.cpp, line 431 > > > > > > We should remove this canDecode() as well for the same reason I mention > > in the comment. Resol

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

> On July 12, 2012, 11:04 p.m., Ralf Engels wrote: > > tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp, line 77 > > > > > > If we need to have special code here to ensure a sensible cleanup, > > might w

Re: GSoC update

On Fri, Jul 13, 2012 at 11:36 AM, Phalgun Guduthur wrote: > On Fri, Jul 13, 2012 at 1:02 PM, Bart Cerneels > wrote: >> >> On Wed, Jul 4, 2012 at 4:37 PM, Phalgun Guduthur >> wrote: >> > Hey All! >> > >> > An update on my GSoC project : Semantic Collection for Amarok >> > >> > I have figured out

Re: GSoC update

On Fri, Jul 13, 2012 at 3:06 PM, Phalgun Guduthur < phalgun.gudut...@gmail.com> wrote: > On Fri, Jul 13, 2012 at 1:02 PM, Bart Cerneels wrote: > >> On Wed, Jul 4, 2012 at 4:37 PM, Phalgun Guduthur >> wrote: >> > Hey All! >> > >> > An update on my GSoC project : Semantic Collection for Amarok >> >

Re: GSoC update

On Fri, Jul 13, 2012 at 1:02 PM, Bart Cerneels wrote: > On Wed, Jul 4, 2012 at 4:37 PM, Phalgun Guduthur > wrote: > > Hey All! > > > > An update on my GSoC project : Semantic Collection for Amarok > > > > I have figured out a way to reuse a lot of existing Amarok code. So it > made > > a part of

Re: [Tomahawk Integration] GSoC Report (plus: RFC on git work-flow guideline)

This command is mandatory for all amarok developers: git config branch.master.rebase true the result of this is that all "git pull" commands will do a rebase rather then a merge. Your local commits will be rewritten (parented to origin/master). The prevents the git log to become unreadable because

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/#review15772 --- src/browsers/filebrowser/FileView.cpp

Re: GSoC update

On Wed, Jul 4, 2012 at 4:37 PM, Phalgun Guduthur wrote: > Hey All! > > An update on my GSoC project : Semantic Collection for Amarok > > I have figured out a way to reuse a lot of existing Amarok code. So it made > a part of the code I wrote till now redundant. > > I will be using MemoryCollection