----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105454/ -----------------------------------------------------------
(Updated July 14, 2012, 4:06 a.m.) Review request for Amarok, Matěj Laitl and Sven Krohlas. Changes ------- Added a test method( see review above ). Updated the TrackKey() constructor to initialize integer data members Description ------- Added a unit test for class TrackKey of core/meta/support/MetaKeys Diffs (updated) ----- src/core/meta/support/MetaKeys.h 1a2fc25 src/core/meta/support/MetaKeys.cpp d3fd722 tests/core/meta/CMakeLists.txt 3ae78c9 tests/core/meta/support/CMakeLists.txt PRE-CREATION tests/core/meta/support/TestMetaTrackKey.h PRE-CREATION tests/core/meta/support/TestMetaTrackKey.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105454/diff/ Testing ------- Builds, and runs fine. Output of running test with -v2 flag: ********* Start testing of TestMetaTrackKey ********* Config: Using QTest library 4.8.1, Qt 4.8.1 INFO : TestMetaTrackKey::initTestCase() entering PASS : TestMetaTrackKey::initTestCase() INFO : TestMetaTrackKey::testOperatorAssignment() entering QSYSTEM: TestMetaTrackKey::testOperatorAssignment() qttest(4918)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned INFO : TestMetaTrackKey::testOperatorAssignment() QVERIFY(!( trackKey1 == trackKey2 )) Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaTrackKey.cpp(41)] INFO : TestMetaTrackKey::testOperatorAssignment() QVERIFY(trackKey1 == trackKey2) Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaTrackKey.cpp(45)] PASS : TestMetaTrackKey::testOperatorAssignment() INFO : TestMetaTrackKey::cleanupTestCase() entering PASS : TestMetaTrackKey::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped ********* Finished testing of TestMetaTrackKey ********* Thanks, Jasneet Bhatti
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
