[KDE Bugtracking System] REMINDER: current Amarok regressions

2012-07-06 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions -- Bug 230991: https://bugs.kde.org/show_bug.cgi?id=230991 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-b

Re: mentor to localize amarok

2012-07-06 Thread Teo Mrnjavac
On Thu, Jul 5, 2012 at 4:45 PM, Jaydev Ajit Kumar wrote: > Hi Teo > > i would like to help with help with localization of amarok ,i have been > using amarok and i totally love it ,but when i play songs in Hindi , i do > not get a lyrics list. > this is what i would like to work on , getting th

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti
> On July 6, 2012, 9:57 a.m., Matěj Laitl wrote: > > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 113 > > > > > > You can use m_emittedTrack on the left side here. Also, why don't you > > use QCOM

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/ --- (Updated July 6, 2012, 5:38 p.m.) Review request for Amarok, Matěj Laitl a

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/#review15450 --- Just minor things are left now: tests/core/collections/suppor

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Matěj Laitl
> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote: > > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 94 > > > > > > testCompleteJobKUrl_data() and testCompleteJobQString_data() can share > > code, too

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti
> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote: > > tests/core/collections/support/TestTrackForUrlWorker.h, line 29 > > > > > > Why these are public? Data members should be normally private. Done away with these

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/ --- (Updated July 6, 2012, 8:54 a.m.) Review request for Amarok, Matěj Laitl a