> On July 6, 2012, 9:57 a.m., Matěj Laitl wrote: > > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 113 > > <http://git.reviewboard.kde.org/r/105389/diff/3/?file=71458#file71458line113> > > > > You can use m_emittedTrack on the left side here. Also, why don't you > > use QCOMPARE? It gives better messages in case of error.
Silly me ! Of course private members are accessible within the class. *After effects of sleep deprivation* And the argument you hold here for QCOMPARE is exactly the reason I used it in the previous issue. But yes, it doesn't really matter there but very much here. - Jasneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105389/#review15450 ----------------------------------------------------------- On July 6, 2012, 5:38 p.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105389/ > ----------------------------------------------------------- > > (Updated July 6, 2012, 5:38 p.m.) > > > Review request for Amarok, Matěj Laitl and Sven Krohlas. > > > Description > ------- > > Added unit test for core/collections/support/TrackForUrlWorker > > Just the one slot completeJob() to test. > Tested for both KUrl and QString types of urls. > > > Diffs > ----- > > tests/core/collections/CMakeLists.txt b01b655 > tests/core/collections/support/CMakeLists.txt PRE-CREATION > tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION > tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION > tests/mocks/MockTrackForUrlWorker.h PRE-CREATION > tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105389/diff/ > > > Testing > ------- > > Builds and runs fine. > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
