Jenkins build is still unstable: amarok_master #160

2012-06-20 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

GSoC update : Amarok-Nepomuk

2012-06-20 Thread Phalgun Guduthur
Hello, Its been a while since I updated my progress. I have come up with a working skeletal NepomukCollection and NepomukQueryMaker. The NepomukCollection shows up in the Amarok GUI. The source code can be found here [1] In the following weeks, I will be trying to actually fetch tracks from the

Jenkins build is still unstable: amarok_master #159

2012-06-20 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Jenkins build is still unstable: amarok_master #158

2012-06-20 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Jenkins build is still unstable: amarok_master #157

2012-06-20 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/#review14915 --- This review has been submitted with commit cbc8a6bd0382b1e246e

Jenkins build is still unstable: amarok_master #156

2012-06-20 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/#review14914 --- Ship it! Good and correct test, but my nitpicking clone is som

Re: [amarok] /: partly fix TestPlaylistFileProvider

2012-06-20 Thread Matěj Laitl
On 20. 6. 2012 Sven Krohlas wrote: > Git commit 1714ad3ca1c0cb368d64c5f2a35778ea21fee859 by Sven Krohlas. > Committed on 20/06/2012 at 14:54. > Pushed by krohlas into branch 'master'. > > partly fix TestPlaylistFileProvider > > This one was quite broken. It no longer crashes but still fails. > >

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/#review14913 --- Ship it! Ship It! - Sven Krohlas On June 20, 2012, 2:17 p.m

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/ --- (Updated June 20, 2012, 2:17 p.m.) Review request for Amarok, Bart Cerneel

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Jasneet Bhatti
> On June 20, 2012, 1:09 p.m., Sven Krohlas wrote: > > tests/core/playlists/TestPlaylistFormat.cpp, line 84 > > > > > > You might also want to feed it a string without any . at all. Or > > several of them. Done. An

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/ --- (Updated June 20, 2012, 2:05 p.m.) Review request for Amarok, Bart Cerneel

Re: [amarok] src/playlistmanager/file: Don't hardcode / as directory separator

2012-06-20 Thread Matěj Laitl
On 20. 6. 2012 Sven Krohlas wrote: > Git commit 04dd8cfb4c2767f9c9c4b2f0b087c16b2a2421de by Sven Krohlas. > > Don't hardcode / as directory separator > > Might have caused problems on Windows. I don't know, I don't have a Windows > machine to test. While we are at it: > > diff --git a/src/playlis

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/#review14910 --- tests/core/playlists/TestPlaylistFormat.cpp

Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/ --- Review request for Amarok, Bart Cerneels, Matěj Laitl, and Sven Krohlas. D

Jenkins build is still unstable: amarok_master #155

2012-06-20 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel