> On June 20, 2012, 1:09 p.m., Sven Krohlas wrote:
> > tests/core/playlists/TestPlaylistFormat.cpp, line 84
> > <http://git.reviewboard.kde.org/r/105306/diff/1/?file=69931#file69931line84>
> >
> > You might also want to feed it a string without any . at all. Or
> > several of them.
Done.
And forgot to mention in the diff change description that ${QT_QTGUI_LIBRARY}
was also removed as link target as it isn't needed.
- Jasneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105306/#review14910
-----------------------------------------------------------
On June 20, 2012, 2:05 p.m., Jasneet Bhatti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105306/
> -----------------------------------------------------------
>
> (Updated June 20, 2012, 2:05 p.m.)
>
>
> Review request for Amarok, Bart Cerneels, Matěj Laitl, and Sven Krohlas.
>
>
> Description
> -------
>
> Adds a unit test for core/playlists/PlaylistFormat
>
>
> Diffs
> -----
>
> tests/core/CMakeLists.txt 8f7db22
> tests/core/playlists/CMakeLists.txt PRE-CREATION
> tests/core/playlists/TestPlaylistFormat.h PRE-CREATION
> tests/core/playlists/TestPlaylistFormat.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/105306/diff/
>
>
> Testing
> -------
>
> Compiles, links and runs fine.
>
>
> Thanks,
>
> Jasneet Bhatti
>
>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
