[Bugzilla] Release blockers

2011-08-22 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 277015: http://bugs.kde.org/show_bug.cgi?id=277015 Priority: NOR Severity: minor Platform: Gentoo Packages Assignee: amarok-bugs-d...@kde.org Status: NEW Summary: In U

Re: Review Request: Fixes bug 263640

2011-08-22 Thread Maximilian Kossick
I agree with Bart, it looks pretty good. One thing to be careful of though: you are quite often calling playableUrl() to determine whether the url is accessible. If I remember correctly there is one case, MtpCollection, that has to copy the file to a temporary location before or within playableUrl(

Re: Review Request: Bug 280382: Unable to add applets to Context View (Wrench is absent when zero applets present)

2011-08-22 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102395/#review5909 --- Ship it! Hah, looks like a stupid little logic bug that does ca

Re: Review Request: Update Amarok to work with Cagibi >= 0.2.0 D-BUS API

2011-08-22 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102384/#review5908 --- src/core-impl/collections/upnpcollection/UpnpCollectionFactory.

Re: Review Request: Fixes bug 263640

2011-08-22 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102181/#review5907 --- Hi Sandeep, The patch looks really good, coding style, logic co