----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102395/#review5909 -----------------------------------------------------------
Ship it! Hah, looks like a stupid little logic bug that does cause a rather nasty situation in a specific case. Thanks for fixing it, feel free to commit. - Bart On Aug. 21, 2011, 9:21 a.m., Nikhil Shantanu Marathe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102395/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2011, 9:21 a.m.) > > > Review request for Amarok and Leo Franchi. > > > Summary > ------- > > The fix is that the wrench is created in the constructor. Earlier it was only > being created when an applet was added. > > I cannot however get the wrench to stay right aligned when there are zero > applets, due to some size hint issues I don't have sufficient knowledge of. > > > This addresses bug 280382. > https://bugs.kde.org/show_bug.cgi?id=280382 > > > Diffs > ----- > > src/context/toolbar/AppletToolbar.cpp 2bedf38 > > Diff: http://git.reviewboard.kde.org/r/102395/diff > > > Testing > ------- > > works fine on Amarok git master running on kde master. > > > Thanks, > > Nikhil Shantanu > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
