Re: Review Request: Fixing E-Mail RegExp in LikeBack Dialog

2011-04-21 Thread Michael Düll
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101170/ --- (Updated April 21, 2011, 4:35 p.m.) Review request for Amarok. Changes -

Review Request: Fixing E-Mail RegExp in LikeBack Dialog

2011-04-21 Thread Michael Düll
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101170/ --- Review request for Amarok. Summary --- This fixes the RegExp checking

Re: Grooveshark service implementation.

2011-04-21 Thread Bart Cerneels
On Thu, Apr 21, 2011 at 13:17, Lydia Pintscher wrote: > On Thu, Apr 21, 2011 at 07:09, Krzysztof Klinikowski > wrote: >> Hello, >> >> I don't know how other programmers writting about features that they're >> coding but here's my: >> >> On my spare time I'm working at new feature for Amarok that

Re: Grooveshark service implementation.

2011-04-21 Thread Lydia Pintscher
On Thu, Apr 21, 2011 at 07:09, Krzysztof Klinikowski wrote: > Hello, > > I don't know how other programmers writting about features that they're > coding but here's my: > > On my spare time I'm working at new feature for Amarok that will add > Grooveshark support into our favourite music player :)

Re: Review Request: Add autoscroll function to the lyrics applet.

2011-04-21 Thread Jan Gerrit Marker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101155/ --- (Updated April 21, 2011, 7:58 a.m.) Review request for Amarok. Changes -

Re: Review Request: Add autoscroll function to the lyrics applet.

2011-04-21 Thread Jan Gerrit Marker
> On April 21, 2011, 6:38 a.m., Bart Cerneels wrote: > > src/context/applets/lyrics/LyricsApplet.cpp, line 396 > > > > > > Some trailing whitespace here, when committing please make sure it's > > gone. Okay, will

Re: Review Request: Add autoscroll function to the lyrics applet.

2011-04-21 Thread Jan Gerrit Marker
> On April 21, 2011, 6:36 a.m., Bart Cerneels wrote: > > Didn't test the patch but the concept and code look good. > > > > How many tracks did you test this with? With all lyrics providers? Does the > > scroll line up with the actual song in all of the cases? I think I tested about 20 songs fr

Grooveshark service implementation.

2011-04-21 Thread Krzysztof Klinikowski
Hello, I don't know how other programmers writting about features that they're coding but here's my: On my spare time I'm working at new feature for Amarok that will add Grooveshark support into our favourite music player :) To be honest I have some code already written but there's still a lot to

Review Request: Enable zeitgeist support through phonon

2011-04-21 Thread Trever Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101166/ --- Review request for Amarok. Summary --- A one line (two with comment ;