> On April 21, 2011, 6:38 a.m., Bart Cerneels wrote:
> > src/context/applets/lyrics/LyricsApplet.cpp, line 396
> > <http://git.reviewboard.kde.org/r/101155/diff/1/?file=14756#file14756line396>
> >
> >     Some trailing whitespace here, when committing please make sure it's 
> > gone.

Okay, will have a look over the code for them.


- Jan Gerrit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101155/#review2787
-----------------------------------------------------------


On April 19, 2011, 5:07 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101155/
> -----------------------------------------------------------
> 
> (Updated April 19, 2011, 5:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The text of the current song is automatically scrolled according to the 
> position in the song. If the scrollbar is pressed and moved the autoscroll is 
> disabled till the scollbar is released and it can be disabled/reactivated 
> manually by clicking on an action. Whether autoscrolling is enabled or 
> disabled is saved over Amarok restarts.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/lyrics/LyricsApplet.h 17c91bf 
>   src/context/applets/lyrics/LyricsApplet.cpp a9c6be3 
> 
> Diff: http://git.reviewboard.kde.org/r/101155/diff
> 
> 
> Testing
> -------
> 
> Tested and worked fine.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Reply via email to