Re: Amarok design meeting

2011-03-20 Thread Bart Cerneels
On Sun, Mar 20, 2011 at 15:23, Teo Mrnjavac wrote: > On Fri, Mar 18, 2011 at 14:55, Teo Mrnjavac wrote: >> On Fri, Mar 18, 2011 at 08:20, Bart Cerneels wrote: >>> Now back to implementing that vision. Over. >> >> Hello team, >> >> I have taken the liberty of creating a Doodle poll for our next >

Re: Review Request: Podcast episode filename configuration

2011-03-20 Thread Bart Cerneels
> On March 21, 2011, 6:35 a.m., Bart Cerneels wrote: > > The patch you uploaded doesn't apply, at least that is what reviewboard > > complains about. For easy review please fix it. You need to diff against master instead of just the diff of your last commit. So I couldn't even review the raw p

Re: Review Request: Podcast episode filename configuration

2011-03-20 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review2075 --- The patch you uploaded doesn't apply, at least that is what revi

Usage of system colors in amarok theme

2011-03-20 Thread Manuel Mommertz
Hello, amarok uses a helper class 'SvgTinter' to replace defined colors with system colors. This class is used to load the SVG-file that contains amarok's theme. The rendering of the elements is done by plasma. Since release 4.6 plasma allows SVG's to use different system colors too. This is do

Re: Return Playdarcollection from "the Dead" ;)

2011-03-20 Thread Mark Kretschmann
On Sun, Mar 20, 2011 at 10:07 PM, Stefan Derkits wrote: >>> Means, that a User could (if he/she wants) enable Playdarcollection from >>> the new Plugins Page in Settings. >>> It would be a pitty to leave the PlaydarColllection Code >>> "force-disabled" even in 2.4.1 >> >> As far as I understand, t

Re: Return Playdarcollection from "the Dead" ;)

2011-03-20 Thread Stefan Derkits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey, >> Means, that a User could (if he/she wants) enable Playdarcollection from >> the new Plugins Page in Settings. >> It would be a pitty to leave the PlaydarColllection Code >> "force-disabled" even in 2.4.1 > > As far as I understand, the Tomaha

Bug #263640: JJ: moving a music folder, collection won't inform user of stale reference

2011-03-20 Thread sandeep
Hi, I've decided to work on this. Could someone tell me which part of Amarok this would come under? (playlist,collections etc.) Thanks, Sandeep ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Return Playdarcollection from "the Dead" ;)

2011-03-20 Thread Mark Kretschmann
On Sat, Mar 19, 2011 at 2:06 PM, Stefan Derkits wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hey, > >> I'm against the idea of having a playdar service just for >> configuration. Unless it has actual usable content, like for instance >> your own GPodderService, it should not pollut

Re: Review Request: fix detection of IPod Classic (at least)

2011-03-20 Thread Cristi P
No svn commit access, so I guess you might have to help by committing it :-( Regards. On Sun, Mar 20, 2011 at 12:32 PM, Rick W. Chen wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100889/ > > Ship it! > > Looks good. Works well. Do you

Re: Review Request: fix detection of IPod Classic (at least)

2011-03-20 Thread Cristi Posoiu
> On March 19, 2011, 10:55 p.m., Rick W. Chen wrote: > > Hi, I've got a similar patch in the queue as well. It checks whether the > > parent device's vencor is "Apple". What I need to find out is is this > > heirarchy the same with other gen iproducts or not. Adding a check for 'Apple' might b

Re: Review Request: fix detection of IPod Classic (at least)

2011-03-20 Thread Cristi Posoiu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100889/ --- (Updated March 20, 2011, 8:35 a.m.) Review request for Amarok. Changes -

Re: Review Request: Podcast episode filename configuration

2011-03-20 Thread Sandeep Raghuraman
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/ --- (Updated March 20, 2011, 6:42 p.m.) Review request for Amarok and Bart Cer

Re: Fix for MySQL embedded permissions error on upgrading to MySQL 5.5

2011-03-20 Thread Alex Merry
Isn't this what Ian's eean-mysql5.5.9fix branch fixes? Alex On 20/03/11 17:45, Nikhil Marathe wrote: > Hi, > > If any user/developer updates to MySQL 5.5 (for example Archlinux now > has 5.5.9), there is a bug in the MySQL build > which stops MYSQL_HOME from being treated as the directory to se

Fix for MySQL embedded permissions error on upgrading to MySQL 5.5

2011-03-20 Thread Nikhil Marathe
Hi, If any user/developer updates to MySQL 5.5 (for example Archlinux now has 5.5.9), there is a bug in the MySQL build which stops MYSQL_HOME from being treated as the directory to search for my.cnf. This leads to permissions errors and a crash. BUG report: http://bugs.mysql.com/bug.php?id=59280

Re: Review Request: Fix multiple issues with the lyrics applet/engine

2011-03-20 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100892/ --- (Updated March 20, 2011, 3:52 p.m.) Review request for Amarok and Rick W.

Re: Amarok design meeting

2011-03-20 Thread Teo Mrnjavac
On Fri, Mar 18, 2011 at 14:55, Teo Mrnjavac wrote: > On Fri, Mar 18, 2011 at 08:20, Bart Cerneels wrote: >> Now back to implementing that vision. Over. > > Hello team, > > I have taken the liberty of creating a Doodle poll for our next > meeting [1]. If you wish to attend please add your availabi

Re: Review Request: Filter Editor Dialog "restyling"

2011-03-20 Thread Stefan Derkits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/06/2011 12:53 PM, Stefan Derkits wrote: > Hello, > > On 01/15/2011 09:35 PM, Sergey Ivanov wrote: > >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://git.revi

Re: Review Request: fix detection of IPod Classic (at least)

2011-03-20 Thread Rick W. Chen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100889/#review2056 --- Ship it! Looks good. Works well. Do you have commit access? -