> On March 19, 2011, 10:55 p.m., Rick W. Chen wrote:
> > Hi, I've got a similar patch in the queue as well. It checks whether the
> > parent device's vencor is "Apple". What I need to find out is is this
> > heirarchy the same with other gen iproducts or not.
Adding a check for 'Apple' might be a good thing to do for this patch as well...
As for checking for the hierarchy things - current patch still tries first to
see if the current device has product containing iPod and only *then* checks
the parent ! I'd say it should be pretty safe.
Also, as a FYI, as I posted on the linked forum thread, until the patch goes
live to users, users could use a udev rule, like:
/lib/udev/rules.d/91_myipod.rules:
ENV{ID_FS_UUID}=="3141-5926", ENV{ID_FS_LABEL} ="iPod_cristi",
ENV{ID_FS_LABEL_ENC} = "iPod_cristi"
where FS_UUID needs to be determined first, and label can be changed, but need
to keep it starting with 'iPod'.
- Cristi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100889/#review2051
-----------------------------------------------------------
On March 19, 2011, 5:15 p.m., Cristi Posoiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100889/
> -----------------------------------------------------------
>
> (Updated March 19, 2011, 5:15 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Using KDE 4.6.1 (Mandriva Cooker, x86_64) and Amarok 2.4.0.
> It seems I have the same problem people are complaining in
> http://forum.kde.org/viewtopic.php?f=115&t=93018
>
> Amarok sees my ipod only as a simple usb storage disk, even though in it
> there are those particular directories and files (iPod_Control/,
> SysExtendedInfo, etc).
> When plugging, I get /dev/sdb1 mounted.
> Running solid-hardware list details, KDE Solid is returning for it a Vendor
> name ("Apple") and as product, since it is a partition, the partition label.
> As such, code from .../support/IpodConnectionAssistant.cpp can't match it.
> In Solid data, /dev/sdb shows though the appropriate product string ("iPod").
>
> So, what this code does, is that it tries to do that product string matching
> also on parent's device.
>
>
> Diffs
> -----
>
>
> src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp
> 92339ff
>
> Diff: http://git.reviewboard.kde.org/r/100889/diff
>
>
> Testing
> -------
>
> started amarok and I get to see my ipod + everything on it.
>
>
> Thanks,
>
> Cristi
>
>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
