Re: Review Request: Filter Editor Dialog "restyling"

> On 2010-12-27 21:29:39, Ralf Engels wrote: > > I am a little bit concerned about how easy it is to understand. > > > > The main usecase would be to create a filter for just one type. > > So how difficult is it to do that now? > > > > Also the line with the different filter types at the top. T

Re: Review Request: Filter Editor Dialog "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/#review630 --- I am a little bit concerned about how easy it is to understand.

Re: Review Request: Filter Editor Dialog "restyling"

> On 2010-12-27 10:12:49, Mark Kretschmann wrote: > > First impressions from screenshot: > > > > Nice, but the two lines of ratings stars look HUGE. I'm not sure if we have > > these icons available in smaller size, but I think that might look better. > > The rating widget does adjust it's siz

Re: Review Request: "store statistics to file" should not include "rating" - only the play-changing statistics. Rating should be saved along with other tags normally.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100231/#review628 --- The diff looks harmless, but it has text changes, so we need to w

Re: Massive Saved Playlist performance improvement! Testers wanted

I was getting build error *Scanning dependencies of target amarok_massstorage-device [ 96%] [ 96%] Built target amarok_service_opmldirectory Building CXX object src/core-impl/collections/db/sql/device/massstorage/CMakeFiles/amarok_massstorage-device.dir/amarok_massstorage-device_automoc.o Linking

Re: Review Request: Filter Editor Dialog "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/#review625 --- Thanks, this looks a lot better now, I think. Don't have time ri

Re: Review Request: Filter Editor Dialog "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/ --- (Updated 2010-12-27 12:58:32.852794) Review request for Amarok. Changes

Re: Massive Saved Playlist performance improvement! Testers wanted

On Mon, Dec 27, 2010 at 12:39 PM, Bart Cerneels wrote: > I'm looking for people with lot's of saved playlists that have > experienced performace issues to try out this git branch: > http://gitweb.kde.org/clones/amarok/shanachie/stecchinos-amarok.git > > simplest instructions: > git clone git://ano

Re: Bart's suggestion to build release build regularly

On Mon, Dec 27, 2010 at 12:22 PM, Bart Cerneels wrote: > On Mon, Dec 27, 2010 at 10:36, Valorie Zimmerman > wrote: >> I saw notice of this new commit this morning in #amarok: >> >> [01:16] Bart Cerneels master * rv2.3.90-82-geff5427 >> amarok/src/ (5 files in 3 dirs): >> [01:16] Include updated

Re: Bart's suggestion to build release build regularly

On Mon, Dec 27, 2010 at 10:36, Valorie Zimmerman wrote: > I saw notice of this new commit this morning in #amarok: > > [01:16] Bart Cerneels master * rv2.3.90-82-geff5427 > amarok/src/ (5 files in 3 dirs): > [01:16] Include updated category in signal. > [01:16] Also remove one more layoutChange

Re: Review Request: Fix for USB storage mode media players

> On 2010-12-27 09:19:36, Sergey Ivanov wrote: > > src/MediaDeviceCache.cpp, line 89 > > > > > > & has greater priority then &&, parenthesis don't make difference. > > Stefan Derkits wrote: > Parenthesis make no d

Re: Review Request: Fix for USB storage mode media players

> On 2010-12-27 09:19:36, Sergey Ivanov wrote: > > src/MediaDeviceCache.cpp, line 89 > > > > > > & has greater priority then &&, parenthesis don't make difference. Parenthesis make no difference for the compiler (and

Re: Review Request: Filter Editor Dialog "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/#review622 --- First impressions from screenshot: Nice, but the two lines of ra

Re: Review Request: Fix for USB storage mode media players

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100194/#review621 --- src/MediaDeviceCache.cpp

Re: Review Request: Fixed Organize Files Dialog to allow for loading presets when in advanced mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100244/#review619 --- Ship it! Looks good. - Sergey On 2010-12-25 21:34:18, Philipp

Re: Review Request: "store statistics to file" should not include "rating" - only the play-changing statistics. Rating should be saved along with other tags normally.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100231/#review618 --- Ship it! Looks good. - Sergey On 2010-12-21 17:04:14, Alan Ez