Re: Review Request: Capability cleanup

2010-11-15 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100153/#review343 --- Rick noticed that contextualActions were commented out. That was

Re: Review Request: Album Artist. Further support improvements

2010-11-15 Thread Ralf Engels
> On 2010-11-15 15:33:36, Ralf Engels wrote: > > Regarding the noCompilation of the collection scanner. > > Actually this makes sense. > > > > The collection scanner has a lot of heuristics for detecting if an album is > > a compilation. > > However we also have a compilation tag. > > If the ta

Changes in the LyricsApplet

2010-11-15 Thread Martin
Hi, I just merged my "improve lyrics handling" patch. Only one change should be visible to the end-user: the use of Applet::showMessage() in the applet. This is used by my new "changes might get lost..." warning (see [0]). Additionally I ported the existing "if you refetch lyrics your changes mi

Re: Review Request: Improve lyrics applet

2010-11-15 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#review341 --- Ship it! Rick and Leo gave their "go" on IRC. - Martin On 201

Re: Review Request: Album Artist. Further support improvements

2010-11-15 Thread Sergey Ivanov
> On 2010-11-15 15:33:36, Ralf Engels wrote: > > Regarding the noCompilation of the collection scanner. > > Actually this makes sense. > > > > The collection scanner has a lot of heuristics for detecting if an album is > > a compilation. > > However we also have a compilation tag. > > If the ta

Re: Review Request: Album Artist. Further support improvements

2010-11-15 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-15 15:34:42.346771) Review request for Amarok. Changes

Re: Review Request: Album Artist. Further support improvements

2010-11-15 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review339 --- Regarding the noCompilation of the collection scanner. Actually t

Review Request: Capability cleanup

2010-11-15 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100153/ --- Review request for Amarok. Summary --- Rename CustomActionsCapability