----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100153/ -----------------------------------------------------------
Review request for Amarok. Summary ------- Rename CustomActionsCapability to ActionsCapability Use ActionsCapability also as CollectionsCapability Use ActionsCapability as CurrentTrackActionsCapability Move all Bookmark actions to the BookmarkThisCapability adding the check for it at several places. Ensure that all created actions without a parent get one upon usage clearing several memory leaks. Note: The cleanup gets rid of over 600 lines of code with (hopefully) unchanged functionality and better readability. Diffs ----- src/CMakeLists.txt 12bb8f3 src/TrayIcon.cpp f1b0f94 src/browsers/CollectionTreeItem.h 65f7d11 src/browsers/CollectionTreeItem.cpp 46a6326 src/browsers/CollectionTreeView.h 3cf4e70 src/browsers/CollectionTreeView.cpp 2bb894c src/context/applets/albums/AlbumsView.cpp 76a5bb3 src/context/applets/currenttrack/CurrentTrack.h 69a9f6b src/context/applets/currenttrack/CurrentTrack.cpp e48ac95 src/core-impl/collections/audiocd/AudioCdCollection.h fec9665 src/core-impl/collections/audiocd/AudioCdCollection.cpp d0979cf src/core-impl/collections/audiocd/AudioCdCollectionCapability.h 9becc6f src/core-impl/collections/audiocd/AudioCdCollectionCapability.cpp 18eac0b src/core-impl/collections/audiocd/CMakeLists.txt c45c670 src/core-impl/collections/db/sql/CMakeLists.txt 4be4c05 src/core-impl/collections/db/sql/CapabilityDelegate.h 28c8daa src/core-impl/collections/db/sql/CapabilityDelegateImpl.h ea84f74 src/core-impl/collections/db/sql/CapabilityDelegateImpl.cpp fb33fb1 src/core-impl/collections/db/sql/SqlBookmarkThisCapability.h 9418f2f src/core-impl/collections/db/sql/SqlBookmarkThisCapability.cpp fbc41ba src/core-impl/collections/db/sql/SqlCollection.h 80b6495 src/core-impl/collections/db/sql/SqlCollection.cpp 5fb1bca src/core-impl/collections/db/sql/SqlMeta.h 3937660 src/core-impl/collections/db/sql/SqlMeta.cpp 1d70872 src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.h 5f690ad src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.cpp dc7aa9f src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionCapability.h 67211f6 src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionCapability.cpp 40b9fff src/core-impl/collections/mediadevicecollection/MediaDeviceDecoratorCapability.h 1bcfc8b src/core-impl/collections/mediadevicecollection/MediaDeviceDecoratorCapability.cpp a68a564 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp ec7f5e1 src/core-impl/collections/nepomukcollection/NepomukAlbum.cpp 590a656 src/core-impl/collections/upnpcollection/UpnpMeta.cpp 2628889 src/core-impl/meta/file/File.cpp e170be2 src/core-impl/meta/timecode/TimecodeMeta.cpp 4640abf src/core-impl/podcasts/sql/SqlPodcastMeta.cpp a661e06 src/core/CMakeLists.txt 8272804 src/core/capabilities/ActionsCapability.h PRE-CREATION src/core/capabilities/ActionsCapability.cpp PRE-CREATION src/core/capabilities/BookmarkThisCapability.h 0b0a45b src/core/capabilities/BookmarkThisCapability.cpp 14c5b44 src/core/capabilities/Capability.h 4057144 src/core/capabilities/CollectionCapability.h 003da1f src/core/capabilities/CollectionCapability.cpp e304034 src/core/capabilities/CurrentTrackActionsCapability.h c2bd724 src/core/capabilities/CurrentTrackActionsCapability.cpp d3e52c8 src/core/capabilities/CustomActionsCapability.h 91a403b src/core/capabilities/CustomActionsCapability.cpp 11c44fb src/core/capabilities/DecoratorCapability.h 1069e3e src/core/capabilities/DecoratorCapability.cpp 35c855d src/covermanager/CoverManager.cpp 25a69cb src/playlist/view/PlaylistViewCommon.h 974f1bd src/playlist/view/PlaylistViewCommon.cpp 81e0bdf src/playlist/view/listview/PrettyListView.cpp 527dc84 src/services/ServiceCapabilities.h 7079bff src/services/ServiceCapabilities.cpp 7188abd src/services/ServiceCollectionTreeView.cpp 7ebc61b src/services/ServiceMetaBase.h 178aaec src/services/ServiceMetaBase.cpp 94cd025 src/services/lastfm/meta/LastFmMeta.h 5c23452 src/services/lastfm/meta/LastFmMeta.cpp 444ceb6 src/toolbar/CurrentTrackToolbar.cpp c180f90 src/toolbar/MainToolbar.cpp e8dbd5b tests/core-impl/collections/sqlcollection/TestSqlAlbum.cpp 3aeb575 Diff: http://git.reviewboard.kde.org/r/100153/diff Testing ------- Tried all track/album/collection actions I could find. Also with a audio cd (which has an eject action) Thanks, Ralf
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
