[Bug 867424]
(In reply to desrt from comment #16) > There is really no good reason for this code to exist anymore. I ended up > with libgnome installed as a dependency for another old program and my > Firefox install started misbehaving as a (nearly untracable) sideeffect of > that. It took me quite a while to figure out that a Firefox bug could be > triggered as a result of installing an unrelated program. > > The fact that I didn't have libgnome installed before, and everything was > working just fine, is as much of an indication as any that this code needs > to die. I think this is explained by bug #557601 comment #8 - firefox blocks shutdown for important asynchronous events when you ask it to quit, but not when the session manager asks. I don't think attachment 608321 addresses this any better than the current code does, so a fix is needed for bug #557601 in any case. I hope someone with more knowledge of asynchronous shutdown can tell whether my analysis is correct and can point to the best way to fix this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
As a minor aside, it would be desirable to do as much work as possible between SaveYourselfCB() and SmcSaveYourselfDone(), and as little as possible between DieCB() and SmcCloseConnection(). At least in KDE, the time-out for the first phase is slightly longer (15 seconds and configurable versus 10 seconds and not configurable IIRC) But probably the convolutions required to accomplish this aren't worth it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Actually, comment #14 is accurate.Calling SmcCloseConnection from
~nsNativeAppSupportUnix should always be safe, as all shutdown phases
will have completed by this point (in the current code)
I managed to understand the shutdown sequence a little better by
attaching gdb and sprinkling some breakpoints around then doing a normal
quit. I couldn't get much direct insight into quit-on-logout as just
attaching a debugger seemed to slow things down enough that firefox
would always SIGHUP, but from my newly-aqcquired understanding, the code
paths *are* the same.
Breakpoint 7, nsObserverService::NotifyObservers (this=0x7f029b4d0330,
aSubject=0x0, aTopic=0x7f02b12745a1 "profile-before-change",
aSomeData=0x7f02b1592000
u"shutdown-persist") at
/usr/src/debug/firefox-37.0.1/mozilla-release/xpcom/ds/nsObserverService.cpp:319
319 {
[Current thread is 1 (Thread 0x7f02b3d5f780 (LWP 8791))]
#0 nsObserverService::NotifyObservers (this=0x7f029b4d0330, aSubject=0x0,
aTopic=0x7f02b12745a1 "profile-before-change", aSomeData=0x7f02b1592000
u"shutdown-persist") at
/usr/src/debug/firefox-37.0.1/mozilla-release/xpcom/ds/nsObserverService.cpp:319
#1 0x7f02b0ab1fe0 in nsXREDirProvider::DoShutdown (this=0x7fffeed02f88) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsXREDirProvider.cpp:905
#2 0x7f02b0aaa102 in ScopedXPCOMStartup::~ScopedXPCOMStartup
(this=0x7f02b29ac7c0, __in_chrg=) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsAppRunner.cpp:1324
#3 0x7f02b0aafc63 in XREMain::XRE_main (this=0x7fffeed02f48,
argc=, argv=, aAppData=) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsAppRunner.cpp:4312
#4 0x7f02b0aafeac in XRE_main (argc=1, argv=0x7fffeed04468,
aAppData=0x7fffeed03158, aFlags=) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsAppRunner.cpp:4505
#5 0x004040fd in do_main (argc=argc@entry=1,
argv=argv@entry=0x7fffeed04468, xreDirectory=0x7f02b2949780) at
/usr/src/debug/firefox-37.0.1/mozilla-release/browser/app/nsBrowserApp.cpp:292
#6 0x0040389f in main (argc=1, argv=0x7fffeed04468) at
/usr/src/debug/firefox-37.0.1/mozilla-release/browser/app/nsBrowserApp.cpp:661
i.e. profile-before-change (and web-workers-shutdown which happens just
after) happens when toolkit/xre/nsAppRunner.cpp:XREMain::XRE_main
destroys the ScopedXPCOMStartup object, just after exiting the event
loop.
Breakpoint 3, nsNativeAppSupportUnix::~nsNativeAppSupportUnix
(this=0x7f02b29e5460, __in_chrg=) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsNativeAppSupportUnix.cpp:126
126 class nsNativeAppSupportUnix : public nsNativeAppSupportBase
[Current thread is 1 (Thread 0x7f02b3d5f780 (LWP 8791))]
#0 nsNativeAppSupportUnix::~nsNativeAppSupportUnix (this=0x7f02b29e5460,
__in_chrg=) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsNativeAppSupportUnix.cpp:126
#1 0x7f02b0ab0e3e in nsNativeAppSupportBase::Release (this=0x7f02b29e5460)
at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsNativeAppSupportBase.cpp:16
#2 0x7f02b0aafebd in XRE_main (argc=1, argv=0x7fffeed04468,
aAppData=0x7fffeed03158, aFlags=) at
/usr/src/debug/firefox-37.0.1/mozilla-release/toolkit/xre/nsAppRunner.cpp:4507
#3 0x004040fd in do_main (argc=argc@entry=1,
argv=argv@entry=0x7fffeed04468, xreDirectory=0x7f02b2949780) at
/usr/src/debug/firefox-37.0.1/mozilla-release/browser/app/nsBrowserApp.cpp:292
#4 0x0040389f in main (argc=1, argv=0x7fffeed04468) at
/usr/src/debug/firefox-37.0.1/mozilla-release/browser/app/nsBrowserApp.cpp:661
...whereas ~nsNativeAppSupportUnix is called when it goes out of scope
when XRE_main returns,so is necessarily later.
As for the appService->Quit() called from die_cb (DieCB in the patch),
it does indeed deliberately queue the work of exiting for after it
returns:
// Quit the application. We will asynchronously call the appshell's
// Exit() method via nsAppExitEvent to allow one last pass
// through any events in the queue. This guarantees a tidy cleanup.
So attachment 608321 (with minor tweaks) should indeed fix bug #557601. I'm not
sure whether it can be fixed in the current code.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/867424
Title:
Oneric: On boot up Firefox always displays the “Well, This Is
Embarrassing” screen.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
(In reply to Bryan Quigley from comment #20) > I'm guessing libsm/libice won't work on wayland? > > Looks like we might be able to get shutdown (but not logout) support from > systemd. -https://wiki.freedesktop.org/www/Software/systemd/inhibit/ Well, the ICE protocol was deliberately independent of the X11 protocol so I guess classical session managers could still work with wayland. In practice, I don't know. A systemd-style logout inhibit would let us delay logout until firefox has saved everything it needs to. But it doesn't provide a way to save restore the position and desktop of each window, as libsm/xsmp does. Nor does it restore applications on the next login or let word-processor style apps restore with the currently-opened file. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8605868 Stop using libgnome and libgnomeui on Linux v2 I've updated the patch above, and have had some success with it, but it still needs some work in order to disconnect from the SM at the right time. It's been compiled and tested a little on top of 37.0.1, it just needed a couple of trivial conflicts resolved to rebase it to master, but hasn't been tested there. Changes from v1 --- * Rebase to 37.0.1 and resolve conflicts - Drop MOZ_WIDGET_GTK == 2 checks - Unbitrot to match "Bug 777292 part 2 - Change all nsnull to nullptr" (Note that this was actually Bug 626472) - Unbitrot to match "Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg" - Unbitrot to match "Bug 784739 - Switch from NULL to nullptr in toolkit/;r=ehsan" - Avoid "Wwrite-strings" warning for static string conversion * Further changes to the functionality of the patch - Don't DisconnectFromSM() until destructor. - Add comments explaining the rationale for disconnect timing wrt shutdown phases - Expand some comments with more detail on the standard or implementation issues - Don't IceSetErrorHandler, and add comment about the motivation for IceSetIOErrorHandler - Rename client_id to prev_client_id; Rename new_client_id to client_id - Set SM_CLIENT_ID on client leader window as per ICCM specified Questions - * Is the #define gtk_function gtk_function_, #undef gtk_function dance in the gtk compat defines the right approach? * are gio watch callbacks always guaranteed to be on the main thread? * what should I use to log instead of printf? Remaining issues * Doesn't solve bug #557601 - DisconnectFromSM is called at the right time when quitting firefox, but is too early on shutdown. I don't understand why yet. * The interaction call/response with the session manager needs some work * Doesn't set a couple of SM properties that gnome-client did * Doesn't use grabs to prevent interaction at the wrong time like gnome-client did -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
To expand on it not yet solving bug #557601 - on normal application quit I see New state = DISCONNECTED after phase "web-workers-shutdown"; on SM-triggered shutdown/quit I've seen it DISCONNECTED just after phase "profile-change-teardown".. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8754796
(2/2) - Stop using libgnome and libgnomeui on Linux v4
Changes from v3
---
* Rebase to master
- Unbitrot to match "Bug 1268313: Part 7 - Move NS_NewRunnableMethod and
friends to mozilla::NewRunnableMethod"
* Set client state to disconnected before closing connection, so that the log
message appears before the actual disconnection.
* Use mozilla::Logging in SetClientState
- The first possible MOZ_LOG user is very early in startup so I need to
add a LogModule::Init() in nsNativeAppSupportUnix::Start as nothing else
has initialised the logging yet.
* Rework setting of SM Properties
- Add helper functions setSMValue, setSMProperty.
- Set all the SM Properties required by the spec
- Try to set a reasonable-ish fallback value if can't determine a correct
value
(NB: XREMain::XRE_mainInit will exit early if AppData->name is not set)
- Warn if setting a fallback value
- Use appropriate name for each SMProp and SMPropValue[]
Solved Issues
-
Tested interaction during shutdown (i.e. "quit-application-requested") by
having multiple tabs open and set browser.showQuitWarning to true, and
patching with:
diff --git a/browser/components/nsBrowserGlue.js
b/browser/components/nsBrowserGlue.js
index eec2e82..ee0d186 100644
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -312,7 +312,7 @@ BrowserGlue.prototype = {
case "session-save":
this._setPrefToSaveSession(true);
subject.QueryInterface(Ci.nsISupportsPRBool);
-subject.data = true;
+subject.data = false;
break;
case "places-init-complete":
if (!this._migrationImportsDefaultBookmarks)
@@ -1377,8 +1377,8 @@ BrowserGlue.prototype = {
// browser.showQuitWarning specifically covers quitting
// browser.tabs.warnOnClose is the global "warn when closing multiple
tabs" pref
-var sessionWillBeRestored =
Services.prefs.getIntPref("browser.startup.page") == 3 ||
-
Services.prefs.getBoolPref("browser.sessionstore.resume_session_once");
+var sessionWillBeRestored = false;
//Services.prefs.getIntPref("browser.startup.page") == 3 ||
+ //
Services.prefs.getBoolPref("browser.sessionstore.resume_session_once");
if (sessionWillBeRestored ||
!Services.prefs.getBoolPref("browser.warnOnQuit"))
return;
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/867424
Title:
Oneric: On boot up Firefox always displays the “Well, This Is
Embarrassing” screen.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8754795 (1/2) - Change modelines to those recommended by coding style -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8737263 Stop using libgnome and libgnomeui on Linux v3 Updated this patch again, and tested on master and on top of 45.0.1. It works with both gtk2 and gtk3 builds but I'd still like feedback about whether I'm doing the right thing with all the gtk plumbing. Solved Issues - "Doesn't solve bug #557601 - DisconnectFromSM is called at the right time when quitting firefox, but is too early on shutdown. I don't understand why yet." This was just PEBKAC. Turns out that if you run your test firefox build from a terminal it will reliably be killed when the terminal quits - who knew? Running with nohup or from e.g. krunner works and firefox survives until it's finished cleaning up. Firefox started by session restore also behaves as expected. Changes from v2 --- * Rebase to master - Unbitrot to match "Bug 1207245 - part 6 - rename nsRefPtr to RefPtr" - Unbitrot: add missing nsThreadUtils.h include * Add keyword for SetClientState logging * Add symbol to mozgtk so that gtk3 builds link * Written a new commit message Questions - * Is the #define gtk_function gtk_function_, #undef gtk_function dance in the gtk compat defines the right approach? * Is the mozgtk stub symbol definition sufficient for gtk3 builds? * are gio watch callbacks always guaranteed to be on the main thread? * what should I use to log instead of printf? What log facilities are still available in late shutdown? Remaining issues * The interaction call/response with the session manager may need some work - in fact it needs to be tested at all. * Doesn't set a couple of SM properties that gnome-client did * Doesn't use grabs to prevent interaction at the wrong time like gnome-client did. But the libegg SM implementation doesn't do anything to prevent interaction, as far as I can tell. So I'm not sure what the correct behaviour is. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
toolkit/xre/nsAppRunner.cpp:SaveToEnv() intentionally leaks memory because it ends up calling putenv(3) which 'leaks' by design and by specification - this was suppressed for valgrind in bug #793534. But I don't understand why this doesn't trigger the leak sanitizer in the existing code - also there's nothing in these patches that touches nsAppRunner.cpp. I can't reproduce this locally but I made a couple of wild guesses as to what change could trigger the lsan warning (https://hg.mozilla.org/try/rev/9770e1ff4923 and https://hg.mozilla.org/try/rev/69de1e6095ae ) but the try job still fails - https://treeherder.mozilla.org/#/jobs?repo=try&revision=59094121359b&selectedJob=22442721 If there was an nspr function that used setenv(3) instead of putenv(3) then the strings would be copied inside libc and the existing lsan suppression for libc would cover this. needinfo'ing mccr8 in case he has any insight into this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8757425
(2/2) - Stop using libgnome and libgnomeui on Linux v5.
Changes from v4
---
Made myself the author, since I deserve the blame even though I don't
deserve the credit. Added a note that Chris Coulson wrote the original
patch. If there's a better way to handle this, perhaps someone with
mercurial-fu can do the magic?
Addressed review comments:
> ::: toolkit/xre/nsNativeAppSupportUnix.cpp
> @@ +429,5 @@
> > +
> > + --gArgc;
> > +}
> > +
> > +static void setSMValue(SmPropValue& val, const nsCString& data)
>
> Please capitalize function names and add a newline after the return type
> declaration in implementations.
>
> Also, this block of code isn't guarded by MOZ_X11. Systems without X11 won't
> be able to resolve SmPropValue.
Done.
>
> @@ +436,5 @@
> > + val.length = data.Length();
> > +}
> > +
> > +static void setSMProperty(SmProp& prop, const char* name, const char* type,
> > + int numVals, SmPropValue vals[])
>
> Style and guard as described above.
and done.
> @@ +491,5 @@
> > +char *arg = *curarg;
> > +if (arg[0] == '-' && arg[1] == '-') {
> > + arg += 2;
> > + if (!strcmp(arg, "sm-disable")) {
> > +RemoveArg(curarg);
>
> Is there any reason we can't just increment argv / decrement argc here
> instead of shifting the char* pointers in RemoveArg?
The argument to remove might be at an arbitrary position in argv, so I
don't think there's a better implementation. Actually, it's copied from
toolkit/xre/nsAppRunner.cpp so might it be worth a followup
de-duplicating it?
>
> @@ +576,5 @@
> > +char errbuf[256];
> > +mSessionConnection = SmcOpenConnection(nullptr, this, SmProtoMajor,
> > + SmProtoMinor, mask, &callbacks,
> > + prev_client_id.get(),
> > &client_id,
> > + 256, errbuf);
>
> Replace 256 with sizeof(errbuf).
Done
Note
An easier way to test interaction during shutdown (i.e.
"quit-application-requested") by having multiple tabs open and set
browser.showQuitWarning to true, then configuring the session manager to
not save state (so it only asks for SmSaveGlobal)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/867424
Title:
Oneric: On boot up Firefox always displays the “Well, This Is
Embarrassing” screen.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24c95faf3d3e is a compile-only try run. Not sure what tests, if any, are suitable. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8763607 (4/4) - Drop unused Xatom.h include Another un-needed include, this one was left over after the removal of the N900 code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8763601 (1/4) - Change modelines to those recommended by coding style. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8763603 (3/4) - Stop using libgnome and libgnomeui on Linux v6. Minor change that I spotted while trying to track down the setenv problem - drop unneeded xlib.h include. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=76ba509b5927 shows the lsan annotation works. Is there any need to re-run the normal try tests from comment #34? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Created attachment 8763602 (2/4) - Annotate deliberate leak in SaveToEnv glandium suggested using MOZ_LSAN_INTENTIONALLY_LEAK_OBJECT directly in the code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
A fairly reduced change is https://hg.mozilla.org/try/rev/def1122a86ba4a17de9da4ed6fa04323c819b753 (with the no-op https://hg.mozilla.org/try/rev/487f69ba0d14 as parent) - see https://treeherder.mozilla.org/#/jobs?repo=try&revision=959751bdb468. I think setenv and putenv share some code in glibc - so perhaps there's some interaction there, i.e. setenv calls prevent putenv leaks but removing the calls reveals them? If the putenv leaks are something that is fixed in later glibc versions (than the try builder uses) that may explain why I can't reproduce this locally. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
(In reply to Andrew McCreight (PTO-ish) [:mccr8] from comment #52) > Comment on attachment 8763602 > (2/4) - Annotate deliberate leak in SaveToEnv > > Review of attachment 8763602: > - > > Be sure to #include "mozilla/MemoryChecking.h" in this file please. It's already there. Which is good, because I can pretend I checked. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1662281] Re: Firefox shows post-crash page after reboot or logoff
** Bug watch added: GNOME Bug Tracker #779306 https://bugzilla.gnome.org/show_bug.cgi?id=779306 ** Also affects: gnome-session via https://bugzilla.gnome.org/show_bug.cgi?id=779306 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662281 Title: Firefox shows post-crash page after reboot or logoff To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-session/+bug/1662281/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1662281] Re: Firefox shows post-crash page after reboot or logoff
This is probably due to gnome-session (mis-)behaviour: My test client gets a "Die" message from the xsm server and within a few tens of milliseconds receives an ICE io error (as the server has quit or broken the connection). According to https://www.x.org/releases/X11R7.7/doc/libSM/SMlib.html#Sending_a_Die_Message the server should wait for clients to close the connection. gnome-session-bin/yakkety,now 3.20.2-1ubuntu7 amd64 [installed,automatic] gnome-session-canberra/yakkety,now 0.30-3ubuntu1 amd64 [installed,automatic] gnome-session-common/yakkety,yakkety,now 3.20.2-1ubuntu7 all [installed,automatic] ** Also affects: gnome-session (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662281 Title: Firefox shows post-crash page after reboot or logoff To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1662281/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1662281] Re: Firefox shows post-crash page after reboot or logoff
Is the environment variable $SESSION_MANAGER set? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662281 Title: Firefox shows post-crash page after reboot or logoff To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1662281/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1072846] [NEW] can't select user from "User Bar" on live image
Public bug reported: When I log out of the kubuntu livecd I can't log in again. This seems to be a problem with the "User Bar" theme. 1. Boot into kubuntu-12.10-desktop-amd64.iso 2. Logout 3. Observe login screen Actual Results: No user icons, just a password field. Entering a blank password doesn't do anything. Expected results: Ability to select the kubuntu user, enter a blank password and login in again. Additional Info: - Entering the "Password and User Account" kcm and changing the image (from a grey box) on the top right doesn't change anything. - Changing to the "Classic" theme allows me to type in "kubuntu" as the username, give a blank password and log in. Packages Affected: lightdm 1.4-0ubuntu2 lightdm-kde-greeter 0.3.0-0ubuntu2 ** Affects: lightdm-kde (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to lightdm-kde in Ubuntu. https://bugs.launchpad.net/bugs/1072846 Title: can't select user from "User Bar" on live image To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lightdm-kde/+bug/1072846/+subscriptions -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 991885]
Is the lid actually closed when this happens, or is it open? If you can reproduce it, please enable "kded" [1] and "7020 kded4" in kdebugdialog and attach the output of 'tail -f .xsession-errors' when this happens. [1] If you can't see this entry first time in kdebugdialog then logout and try again. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to kde-workspace in Ubuntu. https://bugs.launchpad.net/bugs/991885 Title: After the first suspend, KDE suspend the system on every activity switch To manage notifications about this bug go to: https://bugs.launchpad.net/kopete/+bug/991885/+subscriptions -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 184682]
The kde 4.10 screen locker doesn't behave the same, so this shouldn't be happening any more IIRC. If anyone is encountering it on 4.10 and can reproduce it, I'd like to hear details. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/184682 Title: kscreensaver immediately reengages when attempting to connect to the system with VNC To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/184682/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1164876] Re: KDE daemon crashes on wakeup from suspend
This fix is mainly important for https://bugs.kde.org/show_bug.cgi?id=310317 - the xserver bug may also help trigger the crash bug linked above. Ubuntu 13.04 has sufficiently new xorg-server packages to have the fix, it's just 12.10 that needs attention. ** Bug watch added: KDE Bug Tracking System #310317 https://bugs.kde.org/show_bug.cgi?id=310317 ** Package changed: ubuntu => xorg-server (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1164876 Title: KDE daemon crashes on wakeup from suspend To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1164876/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 474654]
The new screen locker should indeed resolve this; if you still see a problem in 4.10, please file a new bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/474654 Title: [SecurityRoadmap] Desktop visible when screen is locked in Kubuntu To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/474654/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1164876] Re: update xserver to fix broken XResetScreenSaver
** Summary changed: - KDE daemon crashes on wakeup from suspend + update xserver to fix broken XResetScreenSaver -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1164876 Title: update xserver to fix broken XResetScreenSaver To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1164876/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 626321]
The discussion linked to from comment #3 certainly suggests that this is in scope for x11/randr. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/626321 Title: X.org server should keep track of and restore its initial (desktop) resolution and refresh rate To manage notifications about this bug go to: https://bugs.launchpad.net/wine/+bug/626321/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
