Created attachment 8754796
(2/2) - Stop using libgnome and libgnomeui on Linux v4
Changes from v3
---------------
* Rebase to master
- Unbitrot to match "Bug 1268313: Part 7 - Move NS_NewRunnableMethod and
friends to mozilla::NewRunnableMethod"
* Set client state to disconnected before closing connection, so that the log
message appears before the actual disconnection.
* Use mozilla::Logging in SetClientState
- The first possible MOZ_LOG user is very early in startup so I need to
add a LogModule::Init() in nsNativeAppSupportUnix::Start as nothing else
has initialised the logging yet.
* Rework setting of SM Properties
- Add helper functions setSMValue, setSMProperty.
- Set all the SM Properties required by the spec
- Try to set a reasonable-ish fallback value if can't determine a correct
value
(NB: XREMain::XRE_mainInit will exit early if AppData->name is not set)
- Warn if setting a fallback value
- Use appropriate name for each SMProp and SMPropValue[]
Solved Issues
-------------
Tested interaction during shutdown (i.e. "quit-application-requested") by
having multiple tabs open and set browser.showQuitWarning to true, and
patching with:
diff --git a/browser/components/nsBrowserGlue.js
b/browser/components/nsBrowserGlue.js
index eec2e82..ee0d186 100644
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -312,7 +312,7 @@ BrowserGlue.prototype = {
case "session-save":
this._setPrefToSaveSession(true);
subject.QueryInterface(Ci.nsISupportsPRBool);
- subject.data = true;
+ subject.data = false;
break;
case "places-init-complete":
if (!this._migrationImportsDefaultBookmarks)
@@ -1377,8 +1377,8 @@ BrowserGlue.prototype = {
// browser.showQuitWarning specifically covers quitting
// browser.tabs.warnOnClose is the global "warn when closing multiple
tabs" pref
- var sessionWillBeRestored =
Services.prefs.getIntPref("browser.startup.page") == 3 ||
-
Services.prefs.getBoolPref("browser.sessionstore.resume_session_once");
+ var sessionWillBeRestored = false;
//Services.prefs.getIntPref("browser.startup.page") == 3 ||
+ //
Services.prefs.getBoolPref("browser.sessionstore.resume_session_once");
if (sessionWillBeRestored ||
!Services.prefs.getBoolPref("browser.warnOnQuit"))
return;
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/867424
Title:
Oneric: On boot up Firefox always displays the “Well, This Is
Embarrassing” screen.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
